Re: [PATCH 4/4] platform:x86: Makefile/Kconfig/MAINTAINERS changes for Intel Telemetry

[Darren Hart <dvhart@infradead.org>]

On Fri, Sep 18, 2015 at 10:15:33AM +0530, Souvik Kumar Chakravarty wrote:
> Makefile, Kconfig & MAINTAINERS changes for compiling Telemetry.
> It depends on PUNIT and PMC IPC drivers.
> 
> Signed-off-by: Souvik Kumar Chakravarty <souvik.k.chakravarty@intel.com>
> ---
>  MAINTAINERS                   |    9 +++++++++
>  drivers/platform/x86/Kconfig  |   16 ++++++++++++++++
>  drivers/platform/x86/Makefile |    2 ++
>  3 files changed, 27 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4d8c8e1..a7f3c1f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5548,6 +5548,15 @@ S:	Maintained
>  F:	drivers/platform/x86/intel_pmc_ipc.c
>  F:	arch/x86/include/asm/intel_pmc_ipc.h
>  
> +INTEL TELEMETRY DRIVER
> +M:	Souvik Kumar Chakravarty <souvik.k.chakravarty@intel.com>
> +L:	platform-driver-x86@vger.kernel.org
> +S:	Maintained
> +F:	drivers/platform/x86/intel_telemetry_core.c
> +F:	drivers/platform/x86/intel_telemetry_pltdrv.c
> +F:	drivers/platform/x86/intel_telemetry_debugfs.c
> +F:	arch/x86/include/asm/intel_telemetry.h
> +
>  IOC3 ETHERNET DRIVER
>  M:	Ralf Baechle <ralf@linux-mips.org>
>  L:	linux-mips@linux-mips.org
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 6dc13e4..7daf453 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -919,4 +919,20 @@ config INTEL_PMC_IPC
>  	The PMC is an ARC processor which defines IPC commands for communication
>  	with other entities in the CPU.
>  
> +config INTEL_PUNIT_IPC
> +        bool "Intel P-UNIT IPC Driver"
> +        ---help---
> +          IPC is used to bridge the communications between kernel and PUNIT
> +
> +config INTEL_TELEMETRY
> +	bool "Intel SoC Telemetry Driver"
> +	def_bool n
> +        depends on INTEL_PMC_IPC && INTEL_PUNIT_IPC && X86_64

Note that this fails to compile with INTL_PMC_IPC is built as a module and this
as a built-in - the result of "make allmodconfig".

> +	---help---
> +	  This driver provides interfaces to configure and use
> +	  telemetry for INTEL SoC from APL onwards. It is also
> +	  used to get various SoC events and parameters
> +	  directly via debugfs files. Various tools may use
> +	  this interface for SoC state monitoring.
> +
>  endif # X86_PLATFORM_DEVICES
> diff --git a/drivers/platform/x86/Makefile b/drivers/platform/x86/Makefile
> index dda95a9..0f99a85 100644
> --- a/drivers/platform/x86/Makefile
> +++ b/drivers/platform/x86/Makefile
> @@ -60,3 +60,5 @@ obj-$(CONFIG_INTEL_SMARTCONNECT)	+= intel-smartconnect.o
>  obj-$(CONFIG_PVPANIC)           += pvpanic.o
>  obj-$(CONFIG_ALIENWARE_WMI)	+= alienware-wmi.o
>  obj-$(CONFIG_INTEL_PMC_IPC)	+= intel_pmc_ipc.o
> +obj-$(CONFIG_INTEL_PUNIT_IPC)	+= intel_punit_ipc.o
> +obj-$(CONFIG_INTEL_TELEMETRY)	+= intel_telemetry_core.o intel_telemetry_pltdrv.o intel_telemetry_debugfs.o
> -- 
> 1.7.9.5
> 
> 

-- 
Darren Hart
Intel Open Source Technology Center