From: Darren Hart <dvhart@infradead.org>
To: Souvik Kumar Chakravarty <souvik.k.chakravarty@intel.com>
Cc: platform-driver-x86@vger.kernel.org, srinidhi.kasagar@intel.com,
qipeng.zha@intel.com
Subject: Re: [PATCH 1/4] platform:x86: Add Intel Telemetry Core Driver
Date: Fri, 18 Sep 2015 12:34:41 -0700 [thread overview]
Message-ID: <20150918193441.GE66179@vmdeb7> (raw)
In-Reply-To: <1442551485-24799-1-git-send-email-souvik.k.chakravarty@intel.com>
On Fri, Sep 18, 2015 at 10:14:45AM +0530, Souvik Kumar Chakravarty wrote:
> Intel PM Telemetry is a software mechanism via which various SoC
> PM and performance related parameters like PM counters, firmware
> trace verbosity, the status of different devices inside the SoC, etc
> can be monitored and analyzed. The different samples that may be
> monitored can be configured at runtime via exported APIs.
>
> This patch adds the telemetry core driver that implements basic
> exported APIs.
>
> Signed-off-by: Souvik Kumar Chakravarty <souvik.k.chakravarty@intel.com>
Hi Souvik,
Each of these trigger some valid issues (mostly coding style) using checkpatch.pl. Please run
checkpatch.pl before sending patches so we don't have to spend time on things
like comparison ordering, block comment formatting, etc.
In my subsequent review, I will not be commenting on things caught be
checkpatch.pl, please run it and incorporate those fixes in your next revision.
Another note, official Intel guidance is to include "All rights reserved."
following the Intel copyright, typically on the following line. You'll find
numerous examples within the kernel.
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2015-09-18 19:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 4:44 [PATCH 1/4] platform:x86: Add Intel Telemetry Core Driver Souvik Kumar Chakravarty
2015-09-18 19:34 ` Darren Hart [this message]
2015-09-18 20:20 ` Darren Hart
-- strict thread matches above, loose matches on Subject: below --
2015-09-14 10:12 Chakravarty, Souvik K
2015-09-17 17:54 ` Darren Hart
2015-09-18 4:29 ` Chakravarty, Souvik K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150918193441.GE66179@vmdeb7 \
--to=dvhart@infradead.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qipeng.zha@intel.com \
--cc=souvik.k.chakravarty@intel.com \
--cc=srinidhi.kasagar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.