From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Sinclair Yeh" Subject: Re: [PATCH 1/2] drm/vmwgfx: Fix uninitialized return in vmw_cotable_unbind() Date: Fri, 18 Sep 2015 15:42:14 -0700 Message-ID: <20150918224214.GA18173@syeh-linux> References: <1442615470-22149-1-git-send-email-cengelma@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from smtp-outbound-2.vmware.com (smtp-outbound-2.vmware.com [208.91.2.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 307FD6E6BF for ; Fri, 18 Sep 2015 15:41:25 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1442615470-22149-1-git-send-email-cengelma@gmx.at> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Christian Engelmayer Cc: thellstrom@vmware.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, charmainel@vmware.com, brianp@vmware.com List-Id: dri-devel@lists.freedesktop.org R29vZCBjYXRjaCEKClJldmlld2VkLWJ5OiBTaW5jbGFpciBZZWggPHN5ZWhAdm13YXJlLmNvbT4K Ck9uIFNhdCwgU2VwIDE5LCAyMDE1IGF0IDEyOjMxOjEwQU0gKzAyMDAsIENocmlzdGlhbiBFbmdl bG1heWVyIHdyb3RlOgo+IEZ1bmN0aW9uIHZtd19jb3RhYmxlX3VuYmluZCgpIHVzZXMgdGhlIHVu aW5pdGlhbGl6ZWQgdmFyaWFibGUgcmV0IGFzCj4gcmV0dXJuIHZhbHVlLiBNYWtlIHRoZSByZXN1 bHQgZGV0ZXJtaW5pc3RpYyBhbmQgZGlyZWN0bHkgcmV0dXJuIGFzCj4gdGhlIHZhcmlhYmxlIGlz IHVudXNlZCBhbnl3YXkuIERldGVjdGVkIGJ5IENvdmVyaXR5IENJRCAxMzI0MjU2Lgo+IAo+IFNp Z25lZC1vZmYtYnk6IENocmlzdGlhbiBFbmdlbG1heWVyIDxjZW5nZWxtYUBnbXguYXQ+Cj4gLS0t Cj4gQ29tcGlsZSB0ZXN0ZWQgb25seS4gQXBwbGllcyBhZ2FpbnN0IGxpbnV4LW5leHQuCj4gLS0t Cj4gIGRyaXZlcnMvZ3B1L2RybS92bXdnZngvdm13Z2Z4X2NvdGFibGUuYyB8IDMgKy0tCj4gIDEg ZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfY290YWJsZS5jIGIvZHJpdmVycy9n cHUvZHJtL3Ztd2dmeC92bXdnZnhfY290YWJsZS5jCj4gaW5kZXggY2U2NTlhMTI1ZjJiLi4wOTJl YTgxZWVmZjcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfY290 YWJsZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdnZnhfY290YWJsZS5jCj4g QEAgLTMxMSw3ICszMTEsNiBAQCBzdGF0aWMgaW50IHZtd19jb3RhYmxlX3VuYmluZChzdHJ1Y3Qg dm13X3Jlc291cmNlICpyZXMsCj4gIAlzdHJ1Y3Qgdm13X3ByaXZhdGUgKmRldl9wcml2ID0gcmVz LT5kZXZfcHJpdjsKPiAgCXN0cnVjdCB0dG1fYnVmZmVyX29iamVjdCAqYm8gPSB2YWxfYnVmLT5i bzsKPiAgCXN0cnVjdCB2bXdfZmVuY2Vfb2JqICpmZW5jZTsKPiAtCWludCByZXQ7Cj4gIAo+ICAJ aWYgKGxpc3RfZW1wdHkoJnJlcy0+bW9iX2hlYWQpKQo+ICAJCXJldHVybiAwOwo+IEBAIC0zMjgs NyArMzI3LDcgQEAgc3RhdGljIGludCB2bXdfY290YWJsZV91bmJpbmQoc3RydWN0IHZtd19yZXNv dXJjZSAqcmVzLAo+ICAJaWYgKGxpa2VseShmZW5jZSAhPSBOVUxMKSkKPiAgCQl2bXdfZmVuY2Vf b2JqX3VucmVmZXJlbmNlKCZmZW5jZSk7Cj4gIAo+IC0JcmV0dXJuIHJldDsKPiArCXJldHVybiAw Owo+ICB9Cj4gIAo+ICAvKioKPiAtLSAKPiAxLjkuMQo+IApfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754522AbbIRWlZ (ORCPT ); Fri, 18 Sep 2015 18:41:25 -0400 Received: from smtp-outbound-2.vmware.com ([208.91.2.13]:38820 "EHLO smtp-outbound-2.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752509AbbIRWlY (ORCPT ); Fri, 18 Sep 2015 18:41:24 -0400 From: "Sinclair Yeh" Date: Fri, 18 Sep 2015 15:42:14 -0700 To: Christian Engelmayer Cc: airlied@linux.ie, thellstrom@vmware.com, brianp@vmware.com, charmainel@vmware.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] drm/vmwgfx: Fix uninitialized return in vmw_cotable_unbind() Message-ID: <20150918224214.GA18173@syeh-linux> References: <1442615470-22149-1-git-send-email-cengelma@gmx.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442615470-22149-1-git-send-email-cengelma@gmx.at> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Good catch! Reviewed-by: Sinclair Yeh On Sat, Sep 19, 2015 at 12:31:10AM +0200, Christian Engelmayer wrote: > Function vmw_cotable_unbind() uses the uninitialized variable ret as > return value. Make the result deterministic and directly return as > the variable is unused anyway. Detected by Coverity CID 1324256. > > Signed-off-by: Christian Engelmayer > --- > Compile tested only. Applies against linux-next. > --- > drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c b/drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c > index ce659a125f2b..092ea81eeff7 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c > @@ -311,7 +311,6 @@ static int vmw_cotable_unbind(struct vmw_resource *res, > struct vmw_private *dev_priv = res->dev_priv; > struct ttm_buffer_object *bo = val_buf->bo; > struct vmw_fence_obj *fence; > - int ret; > > if (list_empty(&res->mob_head)) > return 0; > @@ -328,7 +327,7 @@ static int vmw_cotable_unbind(struct vmw_resource *res, > if (likely(fence != NULL)) > vmw_fence_obj_unreference(&fence); > > - return ret; > + return 0; > } > > /** > -- > 1.9.1 >