All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Chaehyun Lim <chaehyun.lim@gmail.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	rachel.kim@atmel.com, devel@driverdev.osuosl.org,
	chris.park@atmel.com, linux-wireless@vger.kernel.org,
	johnny.kim@atmel.com, "tony.cho" <tony.cho@atmel.com>,
	leo.kim@atmel.com
Subject: Re: [PATCH V2 3/8] staging: wilc1000: replace int8_t with int
Date: Fri, 18 Sep 2015 19:45:16 -0700	[thread overview]
Message-ID: <20150919024516.GA21543@kroah.com> (raw)
In-Reply-To: <CAKV=isvZ2V+RgpB_Aej5cUjZ+n_9OdOb2X_0f=q6=LNouxF14A@mail.gmail.com>

On Thu, Sep 17, 2015 at 09:03:14PM +0900, Chaehyun Lim wrote:
> On Thu, Sep 17, 2015 at 7:34 PM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
> > On Thu, Sep 17, 2015 at 04:48:44PM +0900, Chaehyun Lim wrote:
> >> This patch replaces int8_t with int. just use return type as int.
> >>
> >> Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
> >> ---
> > but isn't int8_t is defined as char?
> >
> 
> Even int8_t is defined as char, I think it's no problem to use int.
> Is it need to change as char?

No, you need to make it a u8 (or s8, depending on the usage).  Be very
careful when changing variable widths.

thanks,

greg k-h

  reply	other threads:[~2015-09-19  4:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17  7:48 [PATCH V2 1/8] staging: wilc1000: remove INLINE macro Chaehyun Lim
2015-09-17  7:48 ` [PATCH V2 2/8] staging: wilc1000: replace __inline with inline Chaehyun Lim
2015-09-17  7:48 ` [PATCH V2 3/8] staging: wilc1000: replace int8_t with int Chaehyun Lim
2015-09-17 10:34   ` Sudip Mukherjee
2015-09-17 12:03     ` Chaehyun Lim
2015-09-19  2:45       ` Greg KH [this message]
2015-09-17  7:48 ` [PATCH V2 4/8] staging: wilc1000: linux_wlan_spi.c: fix kzalloc error check Chaehyun Lim
2015-09-17  7:48 ` [PATCH V2 5/8] staging: wilc1000: remove unused defines Chaehyun Lim
2015-09-17  7:48 ` [PATCH V2 6/8] staging: wilc1000: remove WILC_TIME typedef Chaehyun Lim
2015-09-17  7:48 ` [PATCH V2 7/8] staging: wilc1000: remove useless comment Chaehyun Lim
2015-09-17  7:48 ` [PATCH V2 8/8] staging: wilc1000: remove declaration of wilc_get_chipid Chaehyun Lim
2015-09-17 10:24 ` [PATCH V2 1/8] staging: wilc1000: remove INLINE macro Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150919024516.GA21543@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=chaehyun.lim@gmail.com \
    --cc=chris.park@atmel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=johnny.kim@atmel.com \
    --cc=leo.kim@atmel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rachel.kim@atmel.com \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=tony.cho@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.