From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55084)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@xilinx.com>) id 1ZdIC1-0004Kw-2n
	for qemu-devel@nongnu.org; Sat, 19 Sep 2015 09:28:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@xilinx.com>) id 1ZdIBx-00053U-Ta
	for qemu-devel@nongnu.org; Sat, 19 Sep 2015 09:28:41 -0400
Received: from mail-bn1on0081.outbound.protection.outlook.com
	([157.56.110.81]:55454
	helo=na01-bn1-obe.outbound.protection.outlook.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@xilinx.com>) id 1ZdIBx-00053I-PN
	for qemu-devel@nongnu.org; Sat, 19 Sep 2015 09:28:37 -0400
Date: Sat, 19 Sep 2015 06:28:32 -0700
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
Message-ID: <20150919132832.GA8060@toto>
References: <1442228028-11622-1-git-send-email-serge.fdrv@gmail.com>
	<CAFEAcA-Y9K_ouYbiqnZ-MtaixTrvuYjQnbwGC2saU4np=uEG-g@mail.gmail.com>
	<CAFEAcA8igd9PhQXMd5BLZ3Y_jx7Puu6BczUw+=xGJ9bEXtqp3Q@mail.gmail.com>
	<55FC3483.90508@gmail.com> <55FC38AE.5070206@gmail.com>
	<CAFEAcA_mf5vokPEQH6LfxJNVe+KvQXPuduxg3L-pgWcWQKoFTQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CAFEAcA_mf5vokPEQH6LfxJNVe+KvQXPuduxg3L-pgWcWQKoFTQ@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] target-arm: implement arm_debug_target_el()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Sergey Fedorov <serge.fdrv@gmail.com>, QEMU Developers <qemu-devel@nongnu.org>

On Fri, Sep 18, 2015 at 05:35:07PM +0100, Peter Maydell wrote:
> On 18 September 2015 at 17:15, Sergey Fedorov <serge.fdrv@gmail.com> wrote:
> > On 18.09.2015 18:57, Sergey Fedorov wrote:
> >> On 18.09.2015 17:11, Peter Maydell wrote:
> >>> On 18 September 2015 at 15:08, Peter Maydell <peter.maydell@linaro.org> wrote:
> >>>> On 14 September 2015 at 11:53, Sergey Fedorov <serge.fdrv@gmail.com> wrote:
> >>>>> Implement debug exception routing according to ARM ARM D2.3.1 Pseudocode
> >>>>> description of routing debug exceptions.
> >>>>>
> >>>>> Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
> >>>>
> >>>> Applied to target-arm.next, thanks.
> >>> ...except it doesn't compile, because we don't have an env->cp15.mdcr_el2.
> >>> Presumably there's some other patch this depends on which you haven't
> >>> submitted yet?
> >>>
> >> Hm... I'll check it :)
> >
> > Sorry, I forgot to check that, but actually this patch depends on
> > another two patches in my local repository. Should I prepare MDCR_EL2
> > patch suitable for mainline or I can just remove this check from
> > arm_debug_target_el()?
> 
> Edgar, do you have a MDCR_EL2 implementation in your tree?
> 
> Otherwise, yes, Sergey, you should provide an MDCR_EL2/HDCR patch
> for mainline I think. It should be fairly easy as it just needs
> to be readable/writable and have the correct access checks.
> Don't forget to provide the AArch32 interface as well as the AArch64
> one, and the "RES0 if EL3 but not EL2" version.
> (See Edgar's recent patches in master for VMPIDR_EL2, VTCR_EL2,
> etc for examples.)

Hi,

Sorry, no, I only have a dummy for MDCR_EL2.. Would be great if Sergey has
something ready.

Best regards,
Edgar