From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/mono: fix linking options for locale_charset
Date: Sun, 20 Sep 2015 15:23:03 +0200 [thread overview]
Message-ID: <20150920152303.78dc79ec@free-electrons.com> (raw)
In-Reply-To: <1441437891-6420-1-git-send-email-angelo.compagnucci@gmail.com>
Dear Angelo Compagnucci,
On Sat, 5 Sep 2015 09:24:51 +0200, Angelo Compagnucci wrote:
> + AC_CHECK_HEADERS(getopt.h sys/select.h sys/time.h sys/wait.h pwd.h langinfo.h iconv.h localcharset.h sys/types.h sys/resource.h)
> ++AC_CHECK_LIB([iconv], [locale_charset],[],[AC_CHECK_LIB([charset], [locale_charset],[LIBS+="-liconv -lcharset"])])
Why are you doing LIBS+="-liconv -lcharset" when locale_charset() is
found is libcharset ?
Here is what the Git configure.ac is doing for the same problem:
# Define CHARSET_LIB if libiconv does not export the locale_charset symbol
# and libcharset does
CHARSET_LIB=
AC_CHECK_LIB([iconv], [locale_charset],
[CHARSET_LIB=-liconv],
[AC_CHECK_LIB([charset], [locale_charset],
[CHARSET_LIB=-lcharset])])
GIT_CONF_SUBST([CHARSET_LIB])
> diff --git a/package/mono/Config.in b/package/mono/Config.in
> index 0f57703..cf18a03 100644
> --- a/package/mono/Config.in
> +++ b/package/mono/Config.in
> @@ -8,7 +8,6 @@ config BR2_PACKAGE_MONO
> depends on BR2_PACKAGE_MONO_ARCH_SUPPORTS
> depends on BR2_TOOLCHAIN_HAS_THREADS
> depends on !BR2_STATIC_LIBS
> - select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
What guarantees you that if libiconv is not available, then libcharset
will be? What will provide the locale_charset() function?
This really need a few more explanations.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-09-20 13:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-05 7:24 [Buildroot] [PATCH] package/mono: fix linking options for locale_charset Angelo Compagnucci
2015-09-20 13:23 ` Thomas Petazzoni [this message]
2015-09-21 6:28 ` Angelo Compagnucci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150920152303.78dc79ec@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.