From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Riku Voipio" <riku.voipio@iki.fi>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] linux-user: fix cmsg conversion in case of multiple headers
Date: Mon, 21 Sep 2015 07:34:15 +0200 [thread overview]
Message-ID: <20150921053415.GA21776@latitude> (raw)
In-Reply-To: <CAFEAcA9Xq7+cEnjCrc5ULjLWVvwGqy4Qg+RDC0JHzLY1vCOygg@mail.gmail.com>
On Fri, Sep 04, 2015 at 01:48:39PM +0100, Peter Maydell wrote:
> On 3 September 2015 at 06:27, Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote:
> > Currently, __target_cmsg_nxthdr compares a pointer derived from
> > target_cmsg against the msg_control field of target_msgh (through
> > subtraction). This failed for me when emulating i386 code under x86_64,
> > because pointers in the host address space and pointers in the guest
> > address space were not the same. This patch passes the initial value of
> > target_cmsg into __target_cmsg_nxthdr.
> >
> > I found and fixed two more related bugs:
> > - __target_cmsg_nxthdr now returns the new cmsg pointer instead of the
> > old one.
> > - tgt_space (in host_to_target_cmsg) doesn't count "sizeof (struct
> > target_cmsghdr)" twice anymore.
> >
> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Ping.
What's the status of this patch?
Regards,
Jonathan
next prev parent reply other threads:[~2015-09-21 5:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 14:50 [Qemu-devel] [PATCH] linux-user: fix host_to_target_cmsg in case of multiple headers Jonathan Neuschäfer
2015-08-27 18:06 ` Peter Maydell
2015-08-29 16:04 ` Jonathan Neuschäfer
2015-08-29 16:35 ` Peter Maydell
2015-08-31 19:27 ` [Qemu-devel] [PATCH] linux-user: fix cmsg conversion " Jonathan Neuschäfer
2015-09-01 15:45 ` Peter Maydell
2015-09-02 3:12 ` Jonathan Neuschäfer
2015-09-03 5:27 ` Jonathan Neuschäfer
2015-09-04 12:48 ` Peter Maydell
2015-09-21 5:34 ` Jonathan Neuschäfer [this message]
2015-09-21 13:13 ` Peter Maydell
2015-09-21 19:45 ` Riku Voipio
2015-09-21 19:50 ` Jonathan Neuschäfer
2015-09-28 13:38 ` Riku Voipio
2015-09-28 22:07 ` Jonathan Neuschäfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150921053415.GA21776@latitude \
--to=j.neuschaefer@gmx.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.