From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Mon, 21 Sep 2015 16:21:51 +0000 Subject: [patch] devres: fix a for loop bounds check Message-Id: <20150921162151.GA5648@mwanda> List-Id: In-Reply-To: <20150916171000.GD3243@mtj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Greg Kroah-Hartman , htejun@gmail.com Cc: Catalin Marinas , Cristian Stoica , Dan Williams , Abhilash Kesavan , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org The iomap[] array has PCIM_IOMAP_MAX (6) elements and not DEVICE_COUNT_RESOURCE (16). This bug was found using a static checker. It may be that the "if (!(mask & (1 << i)))" check means we never actually go past the end of the array in real life. Fixes: ec04b075843d ('iomap: implement pcim_iounmap_regions()') Signed-off-by: Dan Carpenter diff --git a/lib/devres.c b/lib/devres.c index f13a246..8c85672 100644 --- a/lib/devres.c +++ b/lib/devres.c @@ -418,7 +418,7 @@ void pcim_iounmap_regions(struct pci_dev *pdev, int mask) if (!iomap) return; - for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) { + for (i = 0; i < PCIM_IOMAP_MAX; i++) { if (!(mask & (1 << i))) continue; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932581AbbIUQWT (ORCPT ); Mon, 21 Sep 2015 12:22:19 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:25110 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932176AbbIUQWQ (ORCPT ); Mon, 21 Sep 2015 12:22:16 -0400 Date: Mon, 21 Sep 2015 19:21:51 +0300 From: Dan Carpenter To: Greg Kroah-Hartman , htejun@gmail.com Cc: Catalin Marinas , Cristian Stoica , Dan Williams , Abhilash Kesavan , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] devres: fix a for loop bounds check Message-ID: <20150921162151.GA5648@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150916171000.GD3243@mtj.duckdns.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The iomap[] array has PCIM_IOMAP_MAX (6) elements and not DEVICE_COUNT_RESOURCE (16). This bug was found using a static checker. It may be that the "if (!(mask & (1 << i)))" check means we never actually go past the end of the array in real life. Fixes: ec04b075843d ('iomap: implement pcim_iounmap_regions()') Signed-off-by: Dan Carpenter diff --git a/lib/devres.c b/lib/devres.c index f13a246..8c85672 100644 --- a/lib/devres.c +++ b/lib/devres.c @@ -418,7 +418,7 @@ void pcim_iounmap_regions(struct pci_dev *pdev, int mask) if (!iomap) return; - for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) { + for (i = 0; i < PCIM_IOMAP_MAX; i++) { if (!(mask & (1 << i))) continue;