From: Gustavo Padovan <gustavo@padovan.org>
To: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: sw0312.kim@samsung.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 3/4] drm/exynos: cleanup function calling written twice
Date: Mon, 21 Sep 2015 15:26:22 -0300 [thread overview]
Message-ID: <20150921182622.GF5178@joana> (raw)
In-Reply-To: <1442381375-540-3-git-send-email-jy0922.shim@samsung.com>
Hi Joonyoung,
2015-09-16 Joonyoung Shim <jy0922.shim@samsung.com>:
> By if statment, some function callings are written twice. It needs
> several line feed by indentation in if statment. Make to one function
> calling from outside if statment.
>
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> ---
> drivers/gpu/drm/exynos/exynos_drm_gem.c | 56 ++++++++++++++-------------------
> 1 file changed, 23 insertions(+), 33 deletions(-)
Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Gustavo
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-09-21 18:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 5:29 [PATCH 1/4] drm/exynos: remove unnecessary NULL assignment Joonyoung Shim
2015-09-16 5:29 ` [PATCH 2/4] drm/exynos: staticize exynos_drm_gem_init() Joonyoung Shim
2015-09-21 16:10 ` Gustavo Padovan
2015-09-16 5:29 ` [PATCH 3/4] drm/exynos: cleanup function calling written twice Joonyoung Shim
2015-09-21 18:26 ` Gustavo Padovan [this message]
2015-09-16 5:29 ` [PATCH 4/4] drm/exynos: cleanup line feed in exynos_drm_gem_get_ioctl Joonyoung Shim
2015-09-21 18:26 ` Gustavo Padovan
2015-09-21 16:10 ` [PATCH 1/4] drm/exynos: remove unnecessary NULL assignment Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150921182622.GF5178@joana \
--to=gustavo@padovan.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jy0922.shim@samsung.com \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.