From: Stephen Hemminger <stephen@networkplumber.org>
To: Neil Horman <nhorman@redhat.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2] netpoll: Close race condition between poll_one_napi and napi_disable
Date: Tue, 22 Sep 2015 15:09:20 -0700 [thread overview]
Message-ID: <20150922150920.2a830e62@urahara> (raw)
In-Reply-To: <1442952096-31430-1-git-send-email-nhorman@redhat.com>
On Tue, 22 Sep 2015 16:01:36 -0400
Neil Horman <nhorman@redhat.com> wrote:
> + clear_bit(NAPI_STATE_NPSVC, &n->state);
> +
> }
why introduce extra line here?
> + /*
> + * If we set this bit but see that it has already been set,
> + * that indicates that napi has been disabled and we need
> + * to abort this operation
> + */
> +
> + if(test_and_set_bit(NAPI_STATE_NPSVC, &napi->state))
And why introduce line after comment before code.
My preference is to have comment as close to code as possible.
next prev parent reply other threads:[~2015-09-22 22:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 18:00 [RHEL6.6 PATCH] netpoll: Close race condition between poll_one_napi and napi_disable Neil Horman
2015-09-22 19:01 ` Neil Horman
2015-09-22 19:46 ` Alexander Duyck
2015-09-22 19:57 ` Neil Horman
2015-09-22 20:01 ` [PATCH v2] " Neil Horman
2015-09-22 22:09 ` Stephen Hemminger [this message]
2015-09-23 10:39 ` Neil Horman
2015-09-23 18:03 ` David Miller
2015-09-23 18:57 ` [PATCH v3] " Neil Horman
2015-09-23 21:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150922150920.2a830e62@urahara \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.