From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 1/4] ARM: sunxi: Introduce Allwinner for A83T support Date: Tue, 22 Sep 2015 17:51:52 +0200 Message-ID: <20150922155152.GJ4684@lukather> References: <1442936337-3104-1-git-send-email-vishnupatekar0510@gmail.com> <1442936337-3104-2-git-send-email-vishnupatekar0510@gmail.com> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4+NAehRbGTL7rPxz" Return-path: Content-Disposition: inline In-Reply-To: <1442936337-3104-2-git-send-email-vishnupatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Vishnu Patekar Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org, linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, jenskuske-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-gpio@vger.kernel.org --4+NAehRbGTL7rPxz Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Hi, On Tue, Sep 22, 2015 at 11:38:54PM +0800, Vishnu Patekar wrote: > Allwinner A83T is octa-core cortex-a7 based SoC. > It's clock control unit and prcm, pinmux are different from previous sun8i > series. > Its processor cores are arragned in two clusters 4 cores each, > similar to A80. > > Signed-off-by: Vishnu Patekar > --- > Documentation/devicetree/bindings/arm/sunxi.txt | 1 + > arch/arm/mach-sunxi/sunxi.c | 1 + > drivers/clk/sunxi/clk-sunxi.c | 6 ++++++ > 3 files changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.txt b/Documentation/devicetree/bindings/arm/sunxi.txt > index 67da205..cf5ed27 100644 > --- a/Documentation/devicetree/bindings/arm/sunxi.txt > +++ b/Documentation/devicetree/bindings/arm/sunxi.txt > @@ -11,4 +11,5 @@ using one of the following compatible strings: > allwinner,sun8i-a23 > allwinner,sun8i-a33 > allwinner,sun8i-h3 > + allwinner,sun8i-a83t > allwinner,sun9i-a80 > diff --git a/arch/arm/mach-sunxi/sunxi.c b/arch/arm/mach-sunxi/sunxi.c > index 65bab28..b04aefa 100644 > --- a/arch/arm/mach-sunxi/sunxi.c > +++ b/arch/arm/mach-sunxi/sunxi.c > @@ -69,6 +69,7 @@ static const char * const sun8i_board_dt_compat[] = { > "allwinner,sun8i-a23", > "allwinner,sun8i-a33", > "allwinner,sun8i-h3", > + "allwinner,sun8i-a83t", > NULL, > }; > > diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c > index 413070d..f216d5d 100644 > --- a/drivers/clk/sunxi/clk-sunxi.c > +++ b/drivers/clk/sunxi/clk-sunxi.c > @@ -1212,6 +1212,12 @@ CLK_OF_DECLARE(sun6i_a31s_clk_init, "allwinner,sun6i-a31s", sun6i_init_clocks); > CLK_OF_DECLARE(sun8i_a23_clk_init, "allwinner,sun8i-a23", sun6i_init_clocks); > CLK_OF_DECLARE(sun8i_a33_clk_init, "allwinner,sun8i-a33", sun6i_init_clocks); > > +static void __init sun8ia83t_init_clocks(struct device_node *node) Having an underscore between sun8i and a83t would be great :) > +{ > + sunxi_init_clocks(NULL, 0); > +} > +CLK_OF_DECLARE(sun9i_a83t_clk_init, "allwinner,sun8i-a83t", sun8ia83t_init_clocks); ^ Is this a sun9i or sun8i SoC ? Is the list of protected clocks always going to be empty, or will you add some new clocks in that list in the future? Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --4+NAehRbGTL7rPxz-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Tue, 22 Sep 2015 17:51:52 +0200 Subject: [PATCH 1/4] ARM: sunxi: Introduce Allwinner for A83T support In-Reply-To: <1442936337-3104-2-git-send-email-vishnupatekar0510@gmail.com> References: <1442936337-3104-1-git-send-email-vishnupatekar0510@gmail.com> <1442936337-3104-2-git-send-email-vishnupatekar0510@gmail.com> Message-ID: <20150922155152.GJ4684@lukather> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Tue, Sep 22, 2015 at 11:38:54PM +0800, Vishnu Patekar wrote: > Allwinner A83T is octa-core cortex-a7 based SoC. > It's clock control unit and prcm, pinmux are different from previous sun8i > series. > Its processor cores are arragned in two clusters 4 cores each, > similar to A80. > > Signed-off-by: Vishnu Patekar > --- > Documentation/devicetree/bindings/arm/sunxi.txt | 1 + > arch/arm/mach-sunxi/sunxi.c | 1 + > drivers/clk/sunxi/clk-sunxi.c | 6 ++++++ > 3 files changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.txt b/Documentation/devicetree/bindings/arm/sunxi.txt > index 67da205..cf5ed27 100644 > --- a/Documentation/devicetree/bindings/arm/sunxi.txt > +++ b/Documentation/devicetree/bindings/arm/sunxi.txt > @@ -11,4 +11,5 @@ using one of the following compatible strings: > allwinner,sun8i-a23 > allwinner,sun8i-a33 > allwinner,sun8i-h3 > + allwinner,sun8i-a83t > allwinner,sun9i-a80 > diff --git a/arch/arm/mach-sunxi/sunxi.c b/arch/arm/mach-sunxi/sunxi.c > index 65bab28..b04aefa 100644 > --- a/arch/arm/mach-sunxi/sunxi.c > +++ b/arch/arm/mach-sunxi/sunxi.c > @@ -69,6 +69,7 @@ static const char * const sun8i_board_dt_compat[] = { > "allwinner,sun8i-a23", > "allwinner,sun8i-a33", > "allwinner,sun8i-h3", > + "allwinner,sun8i-a83t", > NULL, > }; > > diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c > index 413070d..f216d5d 100644 > --- a/drivers/clk/sunxi/clk-sunxi.c > +++ b/drivers/clk/sunxi/clk-sunxi.c > @@ -1212,6 +1212,12 @@ CLK_OF_DECLARE(sun6i_a31s_clk_init, "allwinner,sun6i-a31s", sun6i_init_clocks); > CLK_OF_DECLARE(sun8i_a23_clk_init, "allwinner,sun8i-a23", sun6i_init_clocks); > CLK_OF_DECLARE(sun8i_a33_clk_init, "allwinner,sun8i-a33", sun6i_init_clocks); > > +static void __init sun8ia83t_init_clocks(struct device_node *node) Having an underscore between sun8i and a83t would be great :) > +{ > + sunxi_init_clocks(NULL, 0); > +} > +CLK_OF_DECLARE(sun9i_a83t_clk_init, "allwinner,sun8i-a83t", sun8ia83t_init_clocks); ^ Is this a sun9i or sun8i SoC ? Is the list of protected clocks always going to be empty, or will you add some new clocks in that list in the future? Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933461AbbIVPx3 (ORCPT ); Tue, 22 Sep 2015 11:53:29 -0400 Received: from down.free-electrons.com ([37.187.137.238]:52260 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933371AbbIVPxZ (ORCPT ); Tue, 22 Sep 2015 11:53:25 -0400 Date: Tue, 22 Sep 2015 17:51:52 +0200 From: Maxime Ripard To: Vishnu Patekar Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, emilio@elopez.com.ar, linus.walleij@linaro.org, jenskuske@gmail.com, hdegoede@redhat.com, wens@csie.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, linux-gpio@vger.kernel.org Subject: Re: [PATCH 1/4] ARM: sunxi: Introduce Allwinner for A83T support Message-ID: <20150922155152.GJ4684@lukather> References: <1442936337-3104-1-git-send-email-vishnupatekar0510@gmail.com> <1442936337-3104-2-git-send-email-vishnupatekar0510@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4+NAehRbGTL7rPxz" Content-Disposition: inline In-Reply-To: <1442936337-3104-2-git-send-email-vishnupatekar0510@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --4+NAehRbGTL7rPxz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Sep 22, 2015 at 11:38:54PM +0800, Vishnu Patekar wrote: > Allwinner A83T is octa-core cortex-a7 based SoC. > It's clock control unit and prcm, pinmux are different from previous sun8i > series. > Its processor cores are arragned in two clusters 4 cores each, > similar to A80. >=20 > Signed-off-by: Vishnu Patekar > --- > Documentation/devicetree/bindings/arm/sunxi.txt | 1 + > arch/arm/mach-sunxi/sunxi.c | 1 + > drivers/clk/sunxi/clk-sunxi.c | 6 ++++++ > 3 files changed, 8 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/arm/sunxi.txt b/Documentat= ion/devicetree/bindings/arm/sunxi.txt > index 67da205..cf5ed27 100644 > --- a/Documentation/devicetree/bindings/arm/sunxi.txt > +++ b/Documentation/devicetree/bindings/arm/sunxi.txt > @@ -11,4 +11,5 @@ using one of the following compatible strings: > allwinner,sun8i-a23 > allwinner,sun8i-a33 > allwinner,sun8i-h3 > + allwinner,sun8i-a83t > allwinner,sun9i-a80 > diff --git a/arch/arm/mach-sunxi/sunxi.c b/arch/arm/mach-sunxi/sunxi.c > index 65bab28..b04aefa 100644 > --- a/arch/arm/mach-sunxi/sunxi.c > +++ b/arch/arm/mach-sunxi/sunxi.c > @@ -69,6 +69,7 @@ static const char * const sun8i_board_dt_compat[] =3D { > "allwinner,sun8i-a23", > "allwinner,sun8i-a33", > "allwinner,sun8i-h3", > + "allwinner,sun8i-a83t", > NULL, > }; > =20 > diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c > index 413070d..f216d5d 100644 > --- a/drivers/clk/sunxi/clk-sunxi.c > +++ b/drivers/clk/sunxi/clk-sunxi.c > @@ -1212,6 +1212,12 @@ CLK_OF_DECLARE(sun6i_a31s_clk_init, "allwinner,sun= 6i-a31s", sun6i_init_clocks); > CLK_OF_DECLARE(sun8i_a23_clk_init, "allwinner,sun8i-a23", sun6i_init_clo= cks); > CLK_OF_DECLARE(sun8i_a33_clk_init, "allwinner,sun8i-a33", sun6i_init_clo= cks); > =20 > +static void __init sun8ia83t_init_clocks(struct device_node *node) Having an underscore between sun8i and a83t would be great :) > +{ > + sunxi_init_clocks(NULL, 0); > +} > +CLK_OF_DECLARE(sun9i_a83t_clk_init, "allwinner,sun8i-a83t", sun8ia83t_in= it_clocks); ^ Is this a sun9i or sun8i SoC ? Is the list of protected clocks always going to be empty, or will you add some new clocks in that list in the future? Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --4+NAehRbGTL7rPxz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWAXkYAAoJEBx+YmzsjxAgz88P/REcKuQ449l+73rd3VZ1h3es VQXsRX4WsTGAgZ9LfcYiqPKN7hH3hrlHkFvKq8hF6z1MJ/GodUMPw6Fw13yhKKny tYuUAL4YEllYXKrC6qliK9+tI7GWIywLZKp71dKVZgrMBHXkw15bgheVMKgY6J6w uHH+pEgAm3ryoOP0/msrKrdjeML+MebwdJhgwEpyGOg7nhubQko/fXqbKDHc2vWf 3lLzQM3wtpRgXnkT2o9YlcP1W8NPH09dM43SxXJcIq5mK8NZ8cEY1uN0ABlpCTug tyfckQNgzOKHGQlB6Gv2r7M0jGtWt/TXgxpL9AjzeYRNiFL6icnEbSuaXwW1MAts HL0eo68kP6up1dmw228a2Jh0W8YlrvRRZx5j9VKAvrAV4p9G0n7HGpxAQMhxha2K jXDg50HkIZe01kbXlZ7u9js8Hhf2TwX97191vvh0cCS3ELnmm6i7VvQWSKzKU1Br 9nNKVmm5V9uzDMSOcZ8xFm3f/C+nuKVB3pqESExFBAvUJDA1MtxlhWX26h1oX/Qq tT35kpgAGG+g3TUHrDQYZGJ/tRIXrVLG0HJYKAHpXHRljM3A8kKa/ENuc5WREx9E QnnnxgJGIDPDC9fQgQYngNiiXrVN7hfs2Wbki8zQXoIqc4CRQfAH+jnUX2D9RnNt qrDk7PiRe+4FBArv8wcK =LWkx -----END PGP SIGNATURE----- --4+NAehRbGTL7rPxz--