From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 1/4] ARM: sunxi: Introduce Allwinner for A83T support Date: Tue, 22 Sep 2015 17:53:13 +0200 Message-ID: <20150922155313.GK4684@lukather> References: <1442936337-3104-1-git-send-email-vishnupatekar0510@gmail.com> <1442936337-3104-2-git-send-email-vishnupatekar0510@gmail.com> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="z1065Qb71w7JK2Vw" Return-path: Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: Vishnu Patekar , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King - ARM Linux , Emilio Lopez , Linus Walleij , Jens Kuske , Hans De Goede , devicetree , linux-arm-kernel , linux-kernel , linux-sunxi , "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-gpio@vger.kernel.org --z1065Qb71w7JK2Vw Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Tue, Sep 22, 2015 at 11:47:40PM +0800, Chen-Yu Tsai wrote: > On Tue, Sep 22, 2015 at 11:38 PM, Vishnu Patekar > wrote: > > Allwinner A83T is octa-core cortex-a7 based SoC. > > It's clock control unit and prcm, pinmux are different from previous sun8i > > series. > > Its processor cores are arragned in two clusters 4 cores each, > > similar to A80. > > > > Signed-off-by: Vishnu Patekar > > --- > > Documentation/devicetree/bindings/arm/sunxi.txt | 1 + > > arch/arm/mach-sunxi/sunxi.c | 1 + > > drivers/clk/sunxi/clk-sunxi.c | 6 ++++++ > > 3 files changed, 8 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.txt b/Documentation/devicetree/bindings/arm/sunxi.txt > > index 67da205..cf5ed27 100644 > > --- a/Documentation/devicetree/bindings/arm/sunxi.txt > > +++ b/Documentation/devicetree/bindings/arm/sunxi.txt > > @@ -11,4 +11,5 @@ using one of the following compatible strings: > > allwinner,sun8i-a23 > > allwinner,sun8i-a33 > > allwinner,sun8i-h3 > > + allwinner,sun8i-a83t > > Alphabetic order please. > > > allwinner,sun9i-a80 > > diff --git a/arch/arm/mach-sunxi/sunxi.c b/arch/arm/mach-sunxi/sunxi.c > > index 65bab28..b04aefa 100644 > > --- a/arch/arm/mach-sunxi/sunxi.c > > +++ b/arch/arm/mach-sunxi/sunxi.c > > @@ -69,6 +69,7 @@ static const char * const sun8i_board_dt_compat[] = { > > "allwinner,sun8i-a23", > > "allwinner,sun8i-a33", > > "allwinner,sun8i-h3", > > + "allwinner,sun8i-a83t", > > Same here. > > > NULL, > > }; > > > > diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c > > index 413070d..f216d5d 100644 > > --- a/drivers/clk/sunxi/clk-sunxi.c > > +++ b/drivers/clk/sunxi/clk-sunxi.c > > @@ -1212,6 +1212,12 @@ CLK_OF_DECLARE(sun6i_a31s_clk_init, "allwinner,sun6i-a31s", sun6i_init_clocks); > > CLK_OF_DECLARE(sun8i_a23_clk_init, "allwinner,sun8i-a23", sun6i_init_clocks); > > CLK_OF_DECLARE(sun8i_a33_clk_init, "allwinner,sun8i-a33", sun6i_init_clocks); > > > > +static void __init sun8ia83t_init_clocks(struct device_node *node) > > +{ > > + sunxi_init_clocks(NULL, 0); > > +} > > +CLK_OF_DECLARE(sun9i_a83t_clk_init, "allwinner,sun8i-a83t", sun8ia83t_init_clocks); > > sun8i? Missing underscore too. > > I think you should add this once you actually have clock support. > Otherwise this call basically does nothing. That's not true, it actually initializes most of the clocks in the system. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --z1065Qb71w7JK2Vw-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Tue, 22 Sep 2015 17:53:13 +0200 Subject: [PATCH 1/4] ARM: sunxi: Introduce Allwinner for A83T support In-Reply-To: References: <1442936337-3104-1-git-send-email-vishnupatekar0510@gmail.com> <1442936337-3104-2-git-send-email-vishnupatekar0510@gmail.com> Message-ID: <20150922155313.GK4684@lukather> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Sep 22, 2015 at 11:47:40PM +0800, Chen-Yu Tsai wrote: > On Tue, Sep 22, 2015 at 11:38 PM, Vishnu Patekar > wrote: > > Allwinner A83T is octa-core cortex-a7 based SoC. > > It's clock control unit and prcm, pinmux are different from previous sun8i > > series. > > Its processor cores are arragned in two clusters 4 cores each, > > similar to A80. > > > > Signed-off-by: Vishnu Patekar > > --- > > Documentation/devicetree/bindings/arm/sunxi.txt | 1 + > > arch/arm/mach-sunxi/sunxi.c | 1 + > > drivers/clk/sunxi/clk-sunxi.c | 6 ++++++ > > 3 files changed, 8 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.txt b/Documentation/devicetree/bindings/arm/sunxi.txt > > index 67da205..cf5ed27 100644 > > --- a/Documentation/devicetree/bindings/arm/sunxi.txt > > +++ b/Documentation/devicetree/bindings/arm/sunxi.txt > > @@ -11,4 +11,5 @@ using one of the following compatible strings: > > allwinner,sun8i-a23 > > allwinner,sun8i-a33 > > allwinner,sun8i-h3 > > + allwinner,sun8i-a83t > > Alphabetic order please. > > > allwinner,sun9i-a80 > > diff --git a/arch/arm/mach-sunxi/sunxi.c b/arch/arm/mach-sunxi/sunxi.c > > index 65bab28..b04aefa 100644 > > --- a/arch/arm/mach-sunxi/sunxi.c > > +++ b/arch/arm/mach-sunxi/sunxi.c > > @@ -69,6 +69,7 @@ static const char * const sun8i_board_dt_compat[] = { > > "allwinner,sun8i-a23", > > "allwinner,sun8i-a33", > > "allwinner,sun8i-h3", > > + "allwinner,sun8i-a83t", > > Same here. > > > NULL, > > }; > > > > diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c > > index 413070d..f216d5d 100644 > > --- a/drivers/clk/sunxi/clk-sunxi.c > > +++ b/drivers/clk/sunxi/clk-sunxi.c > > @@ -1212,6 +1212,12 @@ CLK_OF_DECLARE(sun6i_a31s_clk_init, "allwinner,sun6i-a31s", sun6i_init_clocks); > > CLK_OF_DECLARE(sun8i_a23_clk_init, "allwinner,sun8i-a23", sun6i_init_clocks); > > CLK_OF_DECLARE(sun8i_a33_clk_init, "allwinner,sun8i-a33", sun6i_init_clocks); > > > > +static void __init sun8ia83t_init_clocks(struct device_node *node) > > +{ > > + sunxi_init_clocks(NULL, 0); > > +} > > +CLK_OF_DECLARE(sun9i_a83t_clk_init, "allwinner,sun8i-a83t", sun8ia83t_init_clocks); > > sun8i? Missing underscore too. > > I think you should add this once you actually have clock support. > Otherwise this call basically does nothing. That's not true, it actually initializes most of the clocks in the system. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933619AbbIVPy3 (ORCPT ); Tue, 22 Sep 2015 11:54:29 -0400 Received: from down.free-electrons.com ([37.187.137.238]:52308 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933566AbbIVPyZ (ORCPT ); Tue, 22 Sep 2015 11:54:25 -0400 Date: Tue, 22 Sep 2015 17:53:13 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: Vishnu Patekar , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King - ARM Linux , Emilio Lopez , Linus Walleij , Jens Kuske , Hans De Goede , devicetree , linux-arm-kernel , linux-kernel , linux-sunxi , "linux-gpio@vger.kernel.org" Subject: Re: [PATCH 1/4] ARM: sunxi: Introduce Allwinner for A83T support Message-ID: <20150922155313.GK4684@lukather> References: <1442936337-3104-1-git-send-email-vishnupatekar0510@gmail.com> <1442936337-3104-2-git-send-email-vishnupatekar0510@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="z1065Qb71w7JK2Vw" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --z1065Qb71w7JK2Vw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 22, 2015 at 11:47:40PM +0800, Chen-Yu Tsai wrote: > On Tue, Sep 22, 2015 at 11:38 PM, Vishnu Patekar > wrote: > > Allwinner A83T is octa-core cortex-a7 based SoC. > > It's clock control unit and prcm, pinmux are different from previous su= n8i > > series. > > Its processor cores are arragned in two clusters 4 cores each, > > similar to A80. > > > > Signed-off-by: Vishnu Patekar > > --- > > Documentation/devicetree/bindings/arm/sunxi.txt | 1 + > > arch/arm/mach-sunxi/sunxi.c | 1 + > > drivers/clk/sunxi/clk-sunxi.c | 6 ++++++ > > 3 files changed, 8 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.txt b/Document= ation/devicetree/bindings/arm/sunxi.txt > > index 67da205..cf5ed27 100644 > > --- a/Documentation/devicetree/bindings/arm/sunxi.txt > > +++ b/Documentation/devicetree/bindings/arm/sunxi.txt > > @@ -11,4 +11,5 @@ using one of the following compatible strings: > > allwinner,sun8i-a23 > > allwinner,sun8i-a33 > > allwinner,sun8i-h3 > > + allwinner,sun8i-a83t >=20 > Alphabetic order please. >=20 > > allwinner,sun9i-a80 > > diff --git a/arch/arm/mach-sunxi/sunxi.c b/arch/arm/mach-sunxi/sunxi.c > > index 65bab28..b04aefa 100644 > > --- a/arch/arm/mach-sunxi/sunxi.c > > +++ b/arch/arm/mach-sunxi/sunxi.c > > @@ -69,6 +69,7 @@ static const char * const sun8i_board_dt_compat[] =3D= { > > "allwinner,sun8i-a23", > > "allwinner,sun8i-a33", > > "allwinner,sun8i-h3", > > + "allwinner,sun8i-a83t", >=20 > Same here. >=20 > > NULL, > > }; > > > > diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunx= i.c > > index 413070d..f216d5d 100644 > > --- a/drivers/clk/sunxi/clk-sunxi.c > > +++ b/drivers/clk/sunxi/clk-sunxi.c > > @@ -1212,6 +1212,12 @@ CLK_OF_DECLARE(sun6i_a31s_clk_init, "allwinner,s= un6i-a31s", sun6i_init_clocks); > > CLK_OF_DECLARE(sun8i_a23_clk_init, "allwinner,sun8i-a23", sun6i_init_c= locks); > > CLK_OF_DECLARE(sun8i_a33_clk_init, "allwinner,sun8i-a33", sun6i_init_c= locks); > > > > +static void __init sun8ia83t_init_clocks(struct device_node *node) > > +{ > > + sunxi_init_clocks(NULL, 0); > > +} > > +CLK_OF_DECLARE(sun9i_a83t_clk_init, "allwinner,sun8i-a83t", sun8ia83t_= init_clocks); >=20 > sun8i? Missing underscore too. >=20 > I think you should add this once you actually have clock support. > Otherwise this call basically does nothing. That's not true, it actually initializes most of the clocks in the system. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --z1065Qb71w7JK2Vw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWAXlpAAoJEBx+YmzsjxAgHywP/28BhR/IOpt03VjgaV7B2aKk fBMo89xp4mzijs5MR28m7sIh/lTeSCnoYCSxuOday2iqJpOjnCVrfGLPVbd5bQEm FUYLwIOqotAqWsJ1EXl0p9tiJQ3s+SAHJLnqnJJFdHn00XLa6KFiQAlKueMVgtBO XUSq93jxIgnGcAdH+DJr638vdG3FksjzNlWd0IT2mhUZnhbpvKAdivyeggYE2I3d jxXPKwielvxvLnwFL7PB2pHUkBmSAOpAOtIb3Z8i67Jh2kEWcePBc0pMtQrYfPVM r174bRJEr/BGEBbGd5qZ155HtG3liP/FdKoCyQ/SkX1OkFRh/vTsaLMtO2gCGG0Y +wfluBmgKAfJFFKlsIGE2sLvarHpDKAEWaptfyoJhFfbJMpVB8bLmEN48qvfpX1Z wffbMLqoAyZZ4XKZsvaoSEae9B1TwJo+Ka5Jy4UXT0Z+NrLi4WKUaqZxzuUI+qO9 d3f1J398I/esWd0H/BKLSBN0/n7yyVY0ZyxIVRtkhcXI7LltEovPOP1nT8fOs8YZ Yv/mQ/58aWtQM2FJQV/CYjbYqR7SkEssd6J+XdHCCdO6TXIv9ipurO1N/CgvAvfz 69i4znyyJQavWENy8PY++d1KxAgWAQ+dUBMCcspJLBX3cT243Aq0S2toJv5Y/Og1 2LOh6QplrIVpvlNVAT/B =kw56 -----END PGP SIGNATURE----- --z1065Qb71w7JK2Vw--