From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964796AbbIWAHN (ORCPT ); Tue, 22 Sep 2015 20:07:13 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33242 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934153AbbIWAHM (ORCPT ); Tue, 22 Sep 2015 20:07:12 -0400 Date: Tue, 22 Sep 2015 17:08:50 -0700 From: Andrew Morton To: Baoquan He Cc: yinghai@kernel.org, dyoung@redhat.com, jroedel@suse.de, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, bp@suse.de, linux-kernel@vger.kernel.org Subject: Re: [Patch v4] Do not reserve crashkernel high memory if crashkernel low memory reserving failed Message-Id: <20150922170850.d46e58d9.akpm@linux-foundation.org> In-Reply-To: <20150923000255.GA2569@dhcp-17-102.nay.redhat.com> References: <1442922494-5677-1-git-send-email-bhe@redhat.com> <20150922125410.c7b4e8f47ee7fdf1147e2fa0@linux-foundation.org> <20150923000255.GA2569@dhcp-17-102.nay.redhat.com> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 23 Sep 2015 08:02:55 +0800 Baoquan He wrote: > > > > > } > > > > > > low_base = memblock_find_in_range(low_size, (1ULL<<32), > > > low_size, alignment); > > > > > > if (!low_base) { > > > - if (!auto_set) > > > - pr_info("crashkernel low reservation failed - No suitable area found.\n"); > > > - > > > - return; > > > + pr_info("crashkernel low reservation failed - No suitable area found.\n"); > > > > That's not a terribly useful message. If kdump is now unavailable and > > the operator needs to take some remedial action then we should inform > > them of this. > > > > Also, such a message should have higher severity than KERN_INFO? > > Yes, how about KERN_ERR? It's an unexpected result from kdump side > though it doesn't harm the normal kernel. Sure, KERN_ERR is good. Along with more useful message text.