Re: [PATCH 1/5] common: clock: introduce mdelay_non_interruptible()

[Peter Mamonov <pmamonov@gmail.com>]

On Wed, 23 Sep 2015 00:15:28 +0300
Antony Pavlov <antonynpavlov@gmail.com> wrote:

> On Tue, 22 Sep 2015 18:58:30 +0300
> Peter Mamonov <pmamonov@gmail.com> wrote:
> 
> > Signed-off-by: Peter Mamonov <pmamonov@gmail.com>
> > ---
> >  common/clock.c   | 8 ++++++++
> >  include/clock.h  | 1 +
> >  include/common.h | 1 +
> >  3 files changed, 10 insertions(+)
> > 
> > diff --git a/common/clock.c b/common/clock.c
> > index 35c9e6c..51cf9e4 100644
> > --- a/common/clock.c
> > +++ b/common/clock.c
> > @@ -202,6 +202,14 @@ void mdelay(unsigned long msecs)
> >  }
> >  EXPORT_SYMBOL(mdelay);
> >  
> > +void mdelay_non_interruptible(unsigned long msecs)
> > +{
> > +	uint64_t start = get_time_ns();
> > +
> > +	while(!is_timeout_non_interruptible(start, msecs *
> > MSECOND));
> 
> ERROR: space required before the open parenthesis '('
> #107: FILE: common/clock.c:209:
> +	while(!is_timeout_non_interruptible(start, msecs * MSECOND));
> 
> ERROR: trailing statements should be on next line
> #107: FILE: common/clock.c:209:
> +	while(!is_timeout_non_interruptible(start, msecs * MSECOND));

Same formatting 8 lines above, where I copied this code from :P
Anyway, will fix it tomorrow.

> 
> 
> > +}
> > +EXPORT_SYMBOL(mdelay_non_interruptible);
> > +
> >  int init_clock(struct clocksource *cs)
> >  {
> >  	current_clock = cs;
> > diff --git a/include/clock.h b/include/clock.h
> > index 691befc..68d71d7 100644
> > --- a/include/clock.h
> > +++ b/include/clock.h
> > @@ -38,6 +38,7 @@ int is_timeout_non_interruptible(uint64_t
> > start_ns, uint64_t time_offset_ns); 
> >  void ndelay(unsigned long nsecs);
> >  void mdelay(unsigned long msecs);
> > +void mdelay_non_interruptible (unsigned long msecs);
> >  
> >  #define SECOND ((uint64_t)(1000 * 1000 * 1000))
> >  #define MSECOND ((uint64_t)(1000 * 1000))
> > diff --git a/include/common.h b/include/common.h
> > index 553a7f4..c576908 100644
> > --- a/include/common.h
> > +++ b/include/common.h
> > @@ -72,6 +72,7 @@ void __noreturn poweroff(void);
> >  /* lib_$(ARCH)/time.c */
> >  void	udelay (unsigned long);
> >  void	mdelay (unsigned long);
> > +void	mdelay_non_interruptible (unsigned long);
> >  
> >  /* lib_generic/crc32.c */
> >  uint32_t crc32(uint32_t, const void*, unsigned int);
> > -- 
> > 2.1.4
> > 
> > 
> > _______________________________________________
> > barebox mailing list
> > barebox@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/barebox
> 
> 


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox