From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: jasowang@redhat.com, mst@redhat.com, qemu-devel@nongnu.org,
Changchun.ouyang@hotmail.com,
Changchun Ouyang <changchun.ouyang@intel.com>
Subject: Re: [Qemu-devel] [PATCH v10 6/7] vhost-user: add multiple queue support
Date: Wed, 23 Sep 2015 09:48:21 +0800 [thread overview]
Message-ID: <20150923014821.GZ2339@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <20150922185249.GE13681@thinpad.lan.raisama.net>
On Tue, Sep 22, 2015 at 03:52:49PM -0300, Eduardo Habkost wrote:
> On Fri, Sep 18, 2015 at 10:58:43PM +0800, Yuanhan Liu wrote:
> [...]
> > diff --git a/net/vhost-user.c b/net/vhost-user.c
> > index 93dcecd..4fa3d64 100644
> > --- a/net/vhost-user.c
> > +++ b/net/vhost-user.c
> [...]
> > + if (i == 0) {
> > + max_queues = vhost_net_get_max_queues(s->vhost_net);
>
> This breaks arm-softmmu (and any target that doesn't have CONFIG_VHOST_NET):
Thanks for testing. Will fix it next version.
--yliu
>
> $ make subdir-arm-softmmu
> CC arm-softmmu/hw/net/vhost_net.o
> LINK arm-softmmu/qemu-system-arm
> ../net/vhost-user.o: In function `vhost_user_start':
> /home/ehabkost/rh/proj/virt/qemu/net/vhost-user.c:88: undefined reference to `vhost_net_get_max_queues'
> collect2: error: ld returned 1 exit status
> Makefile:193: recipe for target 'qemu-system-arm' failed
> make[1]: *** [qemu-system-arm] Error 1
> Makefile:184: recipe for target 'subdir-arm-softmmu' failed
> make: *** [subdir-arm-softmmu] Error 2
>
> --
> Eduardo
next prev parent reply other threads:[~2015-09-23 1:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 14:58 [Qemu-devel] [PATCH v10 0/7] vhost-user multiple queue support Yuanhan Liu
2015-09-18 14:58 ` [Qemu-devel] [PATCH v10 1/7] vhost-user: use VHOST_USER_XXX macro for switch statement Yuanhan Liu
2015-09-18 14:58 ` [Qemu-devel] [PATCH v10 2/7] vhost-user: add protocol feature negotiation Yuanhan Liu
2015-09-18 14:58 ` [Qemu-devel] [PATCH v10 3/7] vhost: rename VHOST_RESET_OWNER to VHOST_RESET_DEVICE Yuanhan Liu
2015-09-18 14:58 ` [Qemu-devel] [PATCH v10 4/7] vhost-user: add VHOST_USER_GET_QUEUE_NUM message Yuanhan Liu
2015-09-22 9:56 ` Jason Wang
2015-09-23 2:06 ` Yuanhan Liu
2015-09-18 14:58 ` [Qemu-devel] [PATCH v10 5/7] vhost: introduce vhost_backend_get_vq_index method Yuanhan Liu
2015-09-22 10:01 ` Jason Wang
2015-09-23 12:26 ` Eric Blake
2015-09-18 14:58 ` [Qemu-devel] [PATCH v10 6/7] vhost-user: add multiple queue support Yuanhan Liu
2015-09-22 10:14 ` Jason Wang
2015-09-23 1:57 ` Yuanhan Liu
2015-09-23 2:12 ` Jason Wang
2015-09-23 2:16 ` Yuanhan Liu
2015-09-22 11:53 ` Michael S. Tsirkin
2015-09-22 14:44 ` Eric Blake
2015-09-22 18:52 ` Eduardo Habkost
2015-09-23 1:48 ` Yuanhan Liu [this message]
2015-09-18 14:58 ` [Qemu-devel] [PATCH v10 7/7] vhost-user: add a new message to disable/enable a specific virt queue Yuanhan Liu
2015-09-22 14:47 ` Eric Blake
2015-09-23 2:05 ` Yuanhan Liu
2015-09-23 2:06 ` Eric Blake
2015-09-23 2:12 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150923014821.GZ2339@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=Changchun.ouyang@hotmail.com \
--cc=changchun.ouyang@intel.com \
--cc=ehabkost@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.