All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mykola Golub <mgolub@mirantis.com>
To: Jason Dillaman <dillaman@redhat.com>
Cc: Ceph Development <ceph-devel@vger.kernel.org>
Subject: Re: RBD mirroring CLI proposal ...
Date: Wed, 23 Sep 2015 10:34:22 +0300	[thread overview]
Message-ID: <20150923073421.GB8713@gmail.com> (raw)
In-Reply-To: <20150923063313.GA8713@gmail.com>

On Wed, Sep 23, 2015 at 09:33:14AM +0300, Mykola Golub wrote:

> Also, I am not sure we should specify <pool-name> this way, as it is
> not consistent with other rbd commands. By default rbd operates on
> 'rbd' pool, which can be changed by --pool option.

The same reasoning for these commands:

> > * rbd mirror pool add <remote-pool-spec>
> >         This will register a remote cluster/pool as a peer to the current,
> >         local pool.  All existing mirrored images and all future mirrored
> >         images will have this peer registered as a journal client.
> >
> > * rbd mirror pool remove <remote-pool-spec>
> >         This will deregister a remote cluster/pool as a peer to the
> >         current,
> >         local pool.  All existing mirrored images will have the remote
> >         deregistered from image journals.

I am not sure we need 'pool' here. I would prefer:

  rbd mirror peer add <remote-peer-spec>
  rbd mirror peer remove <remote-peer-spec>
  rbd mirror peer show

Where, <remote-peer-spec> should not necessary contain pool, because
the default could be used or what is specified via '--pool' option.

-- 
Mykola Golub

  reply	other threads:[~2015-09-23  7:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <604040155.31290870.1442846770290.JavaMail.zimbra@redhat.com>
2015-09-21 14:48 ` RBD mirroring CLI proposal Jason Dillaman
2015-09-22  9:28   ` Mykola Golub
2015-09-22 17:32     ` Jason Dillaman
2015-09-23  6:33       ` Mykola Golub
2015-09-23  7:34         ` Mykola Golub [this message]
2015-09-23 13:06           ` Jason Dillaman
2015-09-23  8:48         ` Ilya Dryomov
2015-09-23 13:08           ` Jason Dillaman
2015-09-23 17:58             ` Ilya Dryomov
2015-09-23 18:28               ` Jason Dillaman
2015-09-23 19:15                 ` Ilya Dryomov
2015-09-23 13:04         ` Jason Dillaman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150923073421.GB8713@gmail.com \
    --to=mgolub@mirantis.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=dillaman@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.