From: Dan Carpenter <dan.carpenter@oracle.com>
To: "J. German Rivera" <German.Rivera@freescale.com>
Cc: gregkh@linuxfoundation.org, arnd@arndb.de,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
stuart.yoder@freescale.com, itai.katz@freescale.com,
leoli@freescale.com, scottwood@freescale.com, agraf@suse.de,
bhamciu1@freescale.com, R89243@freescale.com,
bhupesh.sharma@freescale.com, nir.erez@freescale.com,
richard.schmitt@freescale.com
Subject: Re: [PATCH v2 6/6] staging: fsl-mc: up-rev dprc binary interface to v4.0
Date: Wed, 23 Sep 2015 12:26:36 +0300 [thread overview]
Message-ID: <20150923092636.GV5004@mwanda> (raw)
In-Reply-To: <1442963339-32084-7-git-send-email-German.Rivera@freescale.com>
On Tue, Sep 22, 2015 at 06:08:59PM -0500, J. German Rivera wrote:
> /**
> + * dprc_set_obj_label() - Set object label.
> + * @mc_io: Pointer to MC portal's I/O object
> + * @cmd_flags: Command flags; one or more of 'MC_CMD_FLAG_'
> + * @token: Token of DPRC object
> + * @obj_type: Object's type
> + * @obj_id: Object's ID
> + * @label: The required label. The maximum length is 16 chars.
> + *
> + * Return: '0' on Success; Error code otherwise.
> + */
> +int dprc_set_obj_label(struct fsl_mc_io *mc_io,
> + uint32_t cmd_flags,
> + uint16_t token,
> + char *obj_type,
> + int obj_id,
> + char *label);
You can fix it in a later patch, but this documentation belongs in the
.c file instead of the .h file.
regards,
dan carpenter
next prev parent reply other threads:[~2015-09-23 9:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 23:08 [PATCH v2 0/6] staging: fsl-mc: up-rev version of MC interface code J. German Rivera
2015-09-22 23:08 ` [PATCH v2 1/6] staging: fsl-mc: Add new flags field to MC command header J. German Rivera
2015-09-22 23:08 ` [PATCH v2 2/6] staging: fsl-mc: uprev dpmng binary interface to v8.0 J. German Rivera
2015-09-22 23:08 ` [PATCH v2 3/6] staging: fsl-mc: up-rev dpbp binary interface to v2.0 J. German Rivera
2015-09-23 3:08 ` Greg KH
2015-09-22 23:08 ` [PATCH v2 4/6] staging: fsl-mc: up-rev dpmcp " J. German Rivera
2015-09-22 23:08 ` [PATCH v2 5/6] staging: fsl-mc: up-rev dpcon " J. German Rivera
2015-09-22 23:08 ` [PATCH v2 6/6] staging: fsl-mc: up-rev dprc binary interface to v4.0 J. German Rivera
2015-09-23 9:26 ` Dan Carpenter [this message]
2015-09-24 18:39 ` Jose Rivera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150923092636.GV5004@mwanda \
--to=dan.carpenter@oracle.com \
--cc=German.Rivera@freescale.com \
--cc=R89243@freescale.com \
--cc=agraf@suse.de \
--cc=arnd@arndb.de \
--cc=bhamciu1@freescale.com \
--cc=bhupesh.sharma@freescale.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=itai.katz@freescale.com \
--cc=leoli@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nir.erez@freescale.com \
--cc=richard.schmitt@freescale.com \
--cc=scottwood@freescale.com \
--cc=stuart.yoder@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.