From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter <pkrempa@redhat.com>,
ehabkost@redhat.com, mst@redhat.com, qemu-devel@nongnu.org,
Igor Mammedov <imammedo@redhat.com>, Jiri <jdenemar@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] pc: memhotplug: rise minimum DIMM addr/size alignment to 128Mb
Date: Wed, 23 Sep 2015 11:32:59 +0100 [thread overview]
Message-ID: <20150923103259.GE2655@work-vm> (raw)
In-Reply-To: <56027330.9010309@redhat.com>
* Paolo Bonzini (pbonzini@redhat.com) wrote:
>
>
> On 23/09/2015 11:36, Igor Mammedov wrote:
> > Also it's QEMU bug/fault and pushing workaround to upper layers
> > doesn't seem right when it's much easier to do it in QEMU itself.
>
> No, it's virtio's bug. It makes sense to push workaround for guest bugs
> as far from the hypervisor as possible.
But you really don't want to have higher level things having to align
addresses themselves. I could see adding an option for the required
alignment would be OK.
> If we want to increase the alignment in QEMU, I would prefer to have
> natural alignment which makes some sense and happens to work around the
> bug as well. Michael, Eduardo, any third opinions?
>
By natural alignment do you mean that an 'n MB' DIMM gets aligned to 'n MB' ?
Dave
> Paolo
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2015-09-23 10:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 11:50 [Qemu-devel] [PATCH] pc: memhotplug: rise minimum DIMM addr/size alignment to 128Mb Igor Mammedov
2015-09-21 12:22 ` Paolo Bonzini
2015-09-21 13:05 ` Igor Mammedov
2015-09-21 13:13 ` Paolo Bonzini
2015-09-21 13:32 ` Igor Mammedov
2015-09-21 13:38 ` Paolo Bonzini
2015-09-23 9:36 ` Igor Mammedov
2015-09-23 9:38 ` Paolo Bonzini
2015-09-23 10:25 ` Igor Mammedov
2015-09-23 10:32 ` Dr. David Alan Gilbert [this message]
2015-09-21 14:58 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150923103259.GE2655@work-vm \
--to=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jdenemar@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.