From: Yaowei Bai <bywxiaobai@163.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: perex@perex.cz, tiwai@suse.com, k.kozlowski@samsung.com,
elfring@users.sourceforge.net, fabf@skynet.be, lars@metafoo.de,
linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] sound/core/seq: make prioq_match return bool
Date: Wed, 23 Sep 2015 21:29:03 +0800 [thread overview]
Message-ID: <20150923132902.GA4286@bbox> (raw)
In-Reply-To: <1442928492.2018.9.camel@sipsolutions.net>
On Tue, Sep 22, 2015 at 03:28:12PM +0200, Johannes Berg wrote:
> On Tue, 2015-09-22 at 21:22 +0800, Yaowei Bai wrote:
> > On Mon, Sep 21, 2015 at 04:11:00PM +0200, Johannes Berg wrote:
> > >
> > > > -static inline int prioq_match(struct snd_seq_event_cell *cell,
> > > > +static inline bool prioq_match(struct snd_seq_event_cell *cell,
> > > > int client, int timestamp)
> > >
> > > I think you should fix up the indentation now.
> >
> > Sorry, I'm quite a new guy to linux kernel. I think you mean this
> > patch is not appropriate, right?
> >
>
> No, the change itself is fine, but you should fix the indentation there
> so it lines up properly after your change.
OK, will send it ASAP. Thanks.
>
> johannes
prev parent reply other threads:[~2015-09-23 13:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 13:57 [PATCH 1/4] sound/onyx: remove redundant case entry Yaowei Bai
2015-09-21 13:57 ` [PATCH 2/4] sound/i2sbus/core: make format more appropriate Yaowei Bai
2015-09-21 13:57 ` [PATCH 3/4] sound/fabrics/layout: make aoa_fabric_layout_init return directly Yaowei Bai
2015-09-21 13:57 ` [PATCH 4/4] sound/core/seq: make prioq_match return bool Yaowei Bai
2015-09-21 14:11 ` Johannes Berg
2015-09-22 13:22 ` Yaowei Bai
2015-09-22 13:28 ` Johannes Berg
2015-09-23 13:29 ` Yaowei Bai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150923132902.GA4286@bbox \
--to=bywxiaobai@163.com \
--cc=alsa-devel@alsa-project.org \
--cc=elfring@users.sourceforge.net \
--cc=fabf@skynet.be \
--cc=johannes@sipsolutions.net \
--cc=k.kozlowski@samsung.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.