From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754784AbbIWNuY (ORCPT <rfc822;w@1wt.eu>);
	Wed, 23 Sep 2015 09:50:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49272 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754234AbbIWNuW (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 23 Sep 2015 09:50:22 -0400
Date: Wed, 23 Sep 2015 15:50:12 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Matt Fleming <matt@codeblueprint.co.uk>,
        Vinson Lee <vlee@twopensource.com>, rostedt@goodmis.org,
        Jiri Olsa <jolsa@kernel.org>, raphael.beamonte@gmail.com,
        "H. Peter Anvin" <hpa@zytor.com>, LKML <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Namhyung Kim <namhyung@kernel.org>, linux-tip-commits@vger.kernel.org,
        Michael Petlan <mpetlan@redhat.com>
Subject: Re: [tip:perf/core] tools lib api fs: Remove debugfs, tracefs and
 findfs objects
Message-ID: <20150923135012.GC2024@krava.redhat.com>
References: <1441180605-24737-15-git-send-email-jolsa@kernel.org>
 <tip-60a1133a5b39738671eff1e4d77bedc1ee3fa528@git.kernel.org>
 <CAHTgTXWYbtd8B77dva2K=dHS1t-8nV7TtaEpoZFY87Q9XGTfBQ@mail.gmail.com>
 <20150923082302.GA2867@codeblueprint.co.uk>
 <20150923083906.GB2024@krava.redhat.com>
 <20150923134456.GD5041@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150923134456.GD5041@redhat.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 23, 2015 at 10:44:56AM -0300, Arnaldo Carvalho de Melo wrote:

SNIP

> New stuff normally comes with new 'perf test' entries, Intel PT borrowed
> the kernel x86 instruction decoder: added a 'perf test' entry, AFAIK
> there was no similar test for it in the kernel proper, IIRC Masami plans
> to do it.
> 
> The attr one you can look at:
> 
> [acme@zoo linux]$ ls -la tools/perf/tests/attr/test-* | wc -l
> 33
>  
> > AFAIK we have: 
> >   - 'perf test' for perf specific functionality
> >   - 'make -f tests/make' for building
> >   - build framework tests
> > 
> > I 'try' to run those before sending anything out, but we dont have
> > automated thing that would run it any time Arnaldo push new perf/core.
> 
> Well, I do run it in multiple distros, like RHEL5, RHEL6 and RHEL7
> besides Fedora 21.
> 
> We're getting used to tools/{lib,include}/ so this happened, but
> otherwise I don't feel like there are that many problems cropping up as
> you seem to think :-\
> 
> Of course, in these days of CI, I'd love if someone would hook 'make -C
> tools/perf build-test' and 'perf test' somewhere to be run for every
> changeset.

yep, thats what I meant.. having this hooked up to your perf/core
would be big help

jirka