From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: WARNING: CPU: 4 PID: 863 at include/drm/drm_crtc.h:1577 drm_helper_choose_encoder_dpms+0x88/0x90() Date: Wed, 23 Sep 2015 18:06:21 +0200 Message-ID: <20150923160621.GA3446@pd.tnic> References: <20150921133126.GA25475@nazgul.tnic> <20150922202105.GB3453@pd.tnic> <20150923072523.GB3383@phenom.ffwll.local> <20150923085950.GA3440@pd.tnic> <20150923144450.GD3383@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.skyhub.de (mail.skyhub.de [78.46.96.112]) by gabe.freedesktop.org (Postfix) with ESMTP id 7C6236E455 for ; Wed, 23 Sep 2015 09:06:24 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20150923144450.GD3383@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Alex Deucher , Christian =?utf-8?B?S8O2bmln?= , Maling list - DRI developers , lkml List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBTZXAgMjMsIDIwMTUgYXQgMDQ6NDQ6NTBQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBzb3JyeSBJIHNwcmlua2xlZCB0aGUgbG9ja2luZyBzdHVmZiBpbiB0aGUgd3Jvbmcg cGxhY2VzLiBTdGlsbCBjb25mdXNlZAo+IHdoeSB0aGUgcmVzdW1lIHNpZGUgZG9lc24ndCBibG93 IHVwIGFueXdoZXJlCgpCdXQgaXQgZG9lczoKClsgICA2OS4zOTQyMDRdIEJVRzogdW5hYmxlIHRv IGhhbmRsZSBrZXJuZWwgTlVMTCBwb2ludGVyIGRlcmVmZXJlbmNlIGF0IDAwMDAwMDAwMDAwMDAw MzQKWyAgIDY5LjQwMjA4MF0gSVA6IFs8ZmZmZmZmZmY4MTMyMTI5Nj5dIHBjaV9yZXN0b3JlX21z aV9zdGF0ZSsweDE5Ni8weDI0MApbICAgNjkuNDA4NjI0XSBQR0QgNDE2MmI4MDY3IFBVRCA0MTY1 ODEwNjcgUE1EIDAgClsgICA2OS40MTMxMjJdIE9vcHM6IDAwMDAgWyMxXSBQUkVFTVBUIFNNUCAK WyAgIDY5LjQxNzEwMV0gTW9kdWxlcyBsaW5rZWQgaW46IHR1biBzaGEyNTZfc3NzZTMgc2hhMjU2 X2dlbmVyaWMgZHJiZyBiaW5mbXRfbWlzYyBpcHY2IHZmYXQgZmF0IGZ1c2UgZG1fY3J5cHQgZG1f bW9kIGt2Cm1fYW1kIGt2bSBjcmMzMl9wY2xtdWwgYWVzbmlfaW50ZWwgYWVzX3g4Nl82NCBscncg Z2YxMjhtdWwgZ2x1ZV9oZWxwZXIgYWJsa19oZWxwZXIgY3J5cHRkIGFtZDY0X2VkYWNfbW9kIGVk YWNfbWNlX2FtZCBmYQptMTVoX3Bvd2VyIGsxMHRlbXAgYW1ka2ZkIGFtZF9pb21tdV92MiByYWRl b24gYWNwaV9jcHVmcmVxClsgICA2OS40NDM2NDddIENQVTogNCBQSUQ6IDgxNCBDb21tOiBrd29y a2VyL3UxNjo1IE5vdCB0YWludGVkIDQuMy4wLXJjMisgIzMKWyAgIDY5LjQ1MDQzMF0gSGFyZHdh cmUgbmFtZTogVG8gYmUgZmlsbGVkIGJ5IE8uRS5NLiBUbyBiZSBmaWxsZWQgYnkgTy5FLk0uL001 QTk3IEVWTyBSMi4wLCBCSU9TIDE1MDMgMDEvMTYvMjAxMwpbICAgNjkuNDYwMzM2XSBXb3JrcXVl dWU6IGV2ZW50c191bmJvdW5kIGFzeW5jX3J1bl9lbnRyeV9mbgpbICAgNjkuNDY1NjY3XSB0YXNr OiBmZmZmODgwNDJhMjU1ZjAwIHRpOiBmZmZmODgwNDI4YTY4MDAwIHRhc2sudGk6IGZmZmY4ODA0 MjhhNjgwMDAKWyAgIDY5LjQ3MzE0NV0gUklQOiAwMDEwOls8ZmZmZmZmZmY4MTMyMTI5Nj5dICBb PGZmZmZmZmZmODEzMjEyOTY+XSBwY2lfcmVzdG9yZV9tc2lfc3RhdGUrMHgxOTYvMHgyNDAKWyAg IDY5LjQ4MjEzMV0gUlNQOiAwMDE4OmZmZmY4ODA0MjhhNmJjMjggIEVGTEFHUzogMDAwMTAyODYK WyAgIDY5LjQ4NzQzNl0gUkFYOiAwMDAwMDAwMDAwMDAwMDAwIFJCWDogZmZmZjg4MDQyYTMwODAw MCBSQ1g6IDAwMDAwMDAwMDAwMDAwMDAKWyAgIDY5LjQ5NDU2OF0gUkRYOiAwMDAwMDAwMDAwMDAw MDAxIFJTSTogZmZmZmZmZmY4MTMwNDQ0OCBSREk6IGZmZmZmZmZmODE2YzdhMWIKWyAgIDY5LjUw MTcwMF0gUkJQOiBmZmZmODgwNDI4YTZiYzQwIFIwODogMDAwMDAwMDAwMDAwMDAwMSBSMDk6IDAw MDAwMDAwMDA1MjIwMDAKWyAgIDY5LjUwODgzM10gUjEwOiAwMDAwMDAwMDAwMDAwMDAwIFIxMTog MDAwMDAwMDAwMDAwMDAwMCBSMTI6IDAwMDAwMDAwMDAwMDAwMDAKWyAgIDY5LjUxNTk2NV0gUjEz OiBmZmZmODgwNDJhMzA4N2IwIFIxNDogZmZmZjg4MDQyYTMwODAxMCBSMTU6IGZmZmY4ODA0MmEz MDgwMzgKWyAgIDY5LjUyMzA5N10gRlM6ICAwMDAwN2ZjOTEzMjhhNzAwKDAwMDApIEdTOmZmZmY4 ODA0MmNlMDAwMDAoMDAwMCkga25sR1M6MDAwMDAwMDAwMDAwMDAwMApbICAgNjkuNTMxMTg1XSBD UzogIDAwMTAgRFM6IDAwMDAgRVM6IDAwMDAgQ1IwOiAwMDAwMDAwMDgwMDUwMDNiClsgICA2OS41 MzY5MzFdIENSMjogMDAwMDAwMDAwMDAwMDAzNCBDUjM6IDAwMDAwMDA0MTY0YzcwMDAgQ1I0OiAw MDAwMDAwMDAwMDQwNmUwClsgICA2OS41NDQwNjFdIFN0YWNrOgpbICAgNjkuNTQ2MDczXSAgMDA4 MDAwMmMyYTMwODdiMCAwMDAwMDAwMDAwMDAwMDAwIGZmZmY4ODA0MmEzMDgwMDAgZmZmZjg4MDQy OGE2YmM3OApbICAgNjkuNTUzNTI1XSAgZmZmZmZmZmY4MTMwYzE0MSBmZmZmODgwNDJhMzA4MDk4 IGZmZmY4ODA0MmEzMDgwMDAgMDAwMDAwMDAwMDAwMDAwMApbICAgNjkuNTYwOTk2XSAgZmZmZjg4 MDQyODRlNzdhOCBmZmZmZmZmZjgxOTYxZWYxIGZmZmY4ODA0MjhhNmJjODggZmZmZmZmZmY4MTMw YzJiOApbICAgNjkuNTY4NDUwXSBDYWxsIFRyYWNlOgpbICAgNjkuNTcxMDQ0XSAgWzxmZmZmZmZm ZjgxMzBjMTQxPl0gcGNpX3Jlc3RvcmVfc3RhdGUucGFydC4xOCsweGYxLzB4MjUwClsgICA2OS41 Nzc3MDZdICBbPGZmZmZmZmZmODEzMGMyYjg+XSBwY2lfcmVzdG9yZV9zdGF0ZSsweDE4LzB4MjAK WyAgIDY5LjU4MzU5MV0gIFs8ZmZmZmZmZmY4MTMwZjdmYz5dIHBjaV9wbV9yZXN0b3JlX25vaXJx KzB4NGMvMHhkMApbICAgNjkuNTg5NzM0XSAgWzxmZmZmZmZmZjgxMzBmN2IwPl0gPyBwY2lfcG1f ZnJlZXplX25vaXJxKzB4ZjAvMHhmMApbICAgNjkuNTk1OTY2XSAgWzxmZmZmZmZmZjgxNDZlODQ3 Pl0gZHBtX3J1bl9jYWxsYmFjaysweDc3LzB4MmEwClsgICA2OS42MDE4NTBdICBbPGZmZmZmZmZm ODE0NmViMDM+XSBkZXZpY2VfcmVzdW1lX25vaXJxKzB4OTMvMHgxNTAKWyAgIDY5LjYwNzk5NF0g IFs8ZmZmZmZmZmY4MTQ2ZWJkZD5dIGFzeW5jX3Jlc3VtZV9ub2lycSsweDFkLzB4NTAKWyAgIDY5 LjYxMzk2N10gIFs8ZmZmZmZmZmY4MTA3OGEwNj5dIGFzeW5jX3J1bl9lbnRyeV9mbisweDQ2LzB4 ZjAKWyAgIDY5LjYxOTkzOV0gIFs8ZmZmZmZmZmY4MTA2ZjU0OD5dIHByb2Nlc3Nfb25lX3dvcmsr MHgxZjgvMHg2NDAKWyAgIDY5LjYyNTkxMF0gIFs8ZmZmZmZmZmY4MTA2ZjRhND5dID8gcHJvY2Vz c19vbmVfd29yaysweDE1NC8weDY0MApbICAgNjkuNjMyMDU0XSAgWzxmZmZmZmZmZjgxMDZmOWRi Pl0gd29ya2VyX3RocmVhZCsweDRiLzB4NDQwClsgICA2OS42Mzc2NzddICBbPGZmZmZmZmZmODEw NmY5OTA+XSA/IHByb2Nlc3Nfb25lX3dvcmsrMHg2NDAvMHg2NDAKWyAgIDY5LjY0MzgyMl0gIFs8 ZmZmZmZmZmY4MTA3NWU4Nj5dIGt0aHJlYWQrMHhmNi8weDExMApbICAgNjkuNjQ4OTI3XSAgWzxm ZmZmZmZmZjgxMDc1ZDkwPl0gPyBrdGhyZWFkX2NyZWF0ZV9vbl9ub2RlKzB4MWYwLzB4MWYwClsg ICA2OS42NTU1OTFdICBbPGZmZmZmZmZmODE2Yzg5M2Y+XSByZXRfZnJvbV9mb3JrKzB4M2YvMHg3 MApbICAgNjkuNjYxMTI4XSAgWzxmZmZmZmZmZjgxMDc1ZDkwPl0gPyBrdGhyZWFkX2NyZWF0ZV9v bl9ub2RlKzB4MWYwLzB4MWYwClsgICA2OS42Njc3OTRdIENvZGU6IDY2IDg5IDRkIGVlIDBmIGI3 IGM5IGU4IDc5IDQxIGZlIGZmIDQ4IDg5IGRmIGU4IGQxIDdhIGNlIGZmIDBmIGI2IDUzIDRiIDhi IDczIDM4IDQ4IDhkIDRkIGVlIDQ4IDhiIDdiIDEwIDgzIGMyIDAyIGU4IDFhIDMxIGZlIGZmIDw0 MT4gMGYgYjYgNGMgMjQgMzQgNDEgOGIgNTQgMjQgMzAgYmUgZmYgZmYgZmYgZmYgYzAgZTkgMDQg ODMgZTEgClsgICA2OS42ODc5ODZdIFJJUCAgWzxmZmZmZmZmZjgxMzIxMjk2Pl0gcGNpX3Jlc3Rv cmVfbXNpX3N0YXRlKzB4MTk2LzB4MjQwClsgICA2OS42OTQ3NzJdICBSU1AgPGZmZmY4ODA0Mjhh NmJjMjg+ClsgICA2OS42OTg0MTJdIENSMjogMDAwMDAwMDAwMDAwMDAzNApbICAgNjkuNzAxODc5 XSAtLS1bIGVuZCB0cmFjZSA4MTRkZDhjYzU2ZTQyN2FlIF0tLS0KClRoaXMgaGFwcGVucyBhdCBy ZXN1bWUgLSBJIGNhdWdodCB0aGUgb3V0cHV0IG92ZXIgc2VyaWFsIC0gc2NyZWVuIGlzCmRlYWQs IGl0IGRvZXNuJ3Qgc2hvdyBhbnl0aGluZyBiZWNhdXNlIGl0IHNpbXBseSBsb2NrcyB1cC9wYW5p Y3MuCgo+IC4uLiBPaCB3ZWxsLiBOZXcgcGF0Y2ggYmVsb3cuCgpZZXAsIHRoaXMgb25lIHRvb2sg Y2FyZSBvZiB0aGUgd2FybmluZyBpbgpkcm1faGVscGVyX2Nob29zZV9lbmNvZGVyX2RwbXMoKS4g VGhhbmtzIQoKTm93IEkgbmVlZCB0byBnbyBkZWN5cGhlciB0aGF0IE5VTEwgcHRyIGRlcmVmIGFi b3ZlLgoKLS0gClJlZ2FyZHMvR3J1c3MsCiAgICBCb3Jpcy4KCkVDTyB0aXAgIzEwMTogVHJpbSB5 b3VyIG1haWxzIHdoZW4geW91IHJlcGx5LgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755951AbbIWQG1 (ORCPT ); Wed, 23 Sep 2015 12:06:27 -0400 Received: from mail.skyhub.de ([78.46.96.112]:51127 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755095AbbIWQGY (ORCPT ); Wed, 23 Sep 2015 12:06:24 -0400 Date: Wed, 23 Sep 2015 18:06:21 +0200 From: Borislav Petkov To: Daniel Vetter Cc: Alex Deucher , Alex Deucher , Christian =?utf-8?B?S8O2bmln?= , Maling list - DRI developers , lkml Subject: Re: WARNING: CPU: 4 PID: 863 at include/drm/drm_crtc.h:1577 drm_helper_choose_encoder_dpms+0x88/0x90() Message-ID: <20150923160621.GA3446@pd.tnic> References: <20150921133126.GA25475@nazgul.tnic> <20150922202105.GB3453@pd.tnic> <20150923072523.GB3383@phenom.ffwll.local> <20150923085950.GA3440@pd.tnic> <20150923144450.GD3383@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150923144450.GD3383@phenom.ffwll.local> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 23, 2015 at 04:44:50PM +0200, Daniel Vetter wrote: > sorry I sprinkled the locking stuff in the wrong places. Still confused > why the resume side doesn't blow up anywhere But it does: [ 69.394204] BUG: unable to handle kernel NULL pointer dereference at 0000000000000034 [ 69.402080] IP: [] pci_restore_msi_state+0x196/0x240 [ 69.408624] PGD 4162b8067 PUD 416581067 PMD 0 [ 69.413122] Oops: 0000 [#1] PREEMPT SMP [ 69.417101] Modules linked in: tun sha256_ssse3 sha256_generic drbg binfmt_misc ipv6 vfat fat fuse dm_crypt dm_mod kv m_amd kvm crc32_pclmul aesni_intel aes_x86_64 lrw gf128mul glue_helper ablk_helper cryptd amd64_edac_mod edac_mce_amd fa m15h_power k10temp amdkfd amd_iommu_v2 radeon acpi_cpufreq [ 69.443647] CPU: 4 PID: 814 Comm: kworker/u16:5 Not tainted 4.3.0-rc2+ #3 [ 69.450430] Hardware name: To be filled by O.E.M. To be filled by O.E.M./M5A97 EVO R2.0, BIOS 1503 01/16/2013 [ 69.460336] Workqueue: events_unbound async_run_entry_fn [ 69.465667] task: ffff88042a255f00 ti: ffff880428a68000 task.ti: ffff880428a68000 [ 69.473145] RIP: 0010:[] [] pci_restore_msi_state+0x196/0x240 [ 69.482131] RSP: 0018:ffff880428a6bc28 EFLAGS: 00010286 [ 69.487436] RAX: 0000000000000000 RBX: ffff88042a308000 RCX: 0000000000000000 [ 69.494568] RDX: 0000000000000001 RSI: ffffffff81304448 RDI: ffffffff816c7a1b [ 69.501700] RBP: ffff880428a6bc40 R08: 0000000000000001 R09: 0000000000522000 [ 69.508833] R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000 [ 69.515965] R13: ffff88042a3087b0 R14: ffff88042a308010 R15: ffff88042a308038 [ 69.523097] FS: 00007fc91328a700(0000) GS:ffff88042ce00000(0000) knlGS:0000000000000000 [ 69.531185] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b [ 69.536931] CR2: 0000000000000034 CR3: 00000004164c7000 CR4: 00000000000406e0 [ 69.544061] Stack: [ 69.546073] 0080002c2a3087b0 0000000000000000 ffff88042a308000 ffff880428a6bc78 [ 69.553525] ffffffff8130c141 ffff88042a308098 ffff88042a308000 0000000000000000 [ 69.560996] ffff8804284e77a8 ffffffff81961ef1 ffff880428a6bc88 ffffffff8130c2b8 [ 69.568450] Call Trace: [ 69.571044] [] pci_restore_state.part.18+0xf1/0x250 [ 69.577706] [] pci_restore_state+0x18/0x20 [ 69.583591] [] pci_pm_restore_noirq+0x4c/0xd0 [ 69.589734] [] ? pci_pm_freeze_noirq+0xf0/0xf0 [ 69.595966] [] dpm_run_callback+0x77/0x2a0 [ 69.601850] [] device_resume_noirq+0x93/0x150 [ 69.607994] [] async_resume_noirq+0x1d/0x50 [ 69.613967] [] async_run_entry_fn+0x46/0xf0 [ 69.619939] [] process_one_work+0x1f8/0x640 [ 69.625910] [] ? process_one_work+0x154/0x640 [ 69.632054] [] worker_thread+0x4b/0x440 [ 69.637677] [] ? process_one_work+0x640/0x640 [ 69.643822] [] kthread+0xf6/0x110 [ 69.648927] [] ? kthread_create_on_node+0x1f0/0x1f0 [ 69.655591] [] ret_from_fork+0x3f/0x70 [ 69.661128] [] ? kthread_create_on_node+0x1f0/0x1f0 [ 69.667794] Code: 66 89 4d ee 0f b7 c9 e8 79 41 fe ff 48 89 df e8 d1 7a ce ff 0f b6 53 4b 8b 73 38 48 8d 4d ee 48 8b 7b 10 83 c2 02 e8 1a 31 fe ff <41> 0f b6 4c 24 34 41 8b 54 24 30 be ff ff ff ff c0 e9 04 83 e1 [ 69.687986] RIP [] pci_restore_msi_state+0x196/0x240 [ 69.694772] RSP [ 69.698412] CR2: 0000000000000034 [ 69.701879] ---[ end trace 814dd8cc56e427ae ]--- This happens at resume - I caught the output over serial - screen is dead, it doesn't show anything because it simply locks up/panics. > ... Oh well. New patch below. Yep, this one took care of the warning in drm_helper_choose_encoder_dpms(). Thanks! Now I need to go decypher that NULL ptr deref above. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.