All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Christoph Schulz <develop@kristov.de>
Cc: netdev@vger.kernel.org, Wilhelm Wijkander <lists@0x5e.se>,
	Vadim Kochan <vadim4j@gmail.com>,
	Leonhard Preis <leonhard@pre.is>
Subject: Re: [PATCH] ip: allow using a device "help" (or a prefix thereof)
Date: Wed, 23 Sep 2015 16:07:02 -0700	[thread overview]
Message-ID: <20150923160702.08b62a84@urahara> (raw)
In-Reply-To: <55FBCA11.7070604@kristov.de>

On Fri, 18 Sep 2015 10:23:45 +0200
Christoph Schulz <develop@kristov.de> wrote:

> Device names that match "help" or a prefix thereof should be allowed anywhere
> a device name can be used. Note that a suitable keyword ("dev" or "name", the
> latter for "ip tunnel") has to be used in these cases to resolve ambiguities.
> 
> Signed-off-by: Christoph Schulz <develop@kristov.de>
> Reported-by: Leonhard Preis <leonhard@pre.is>
> Reported-by: Wilhelm Wijkander <lists@0x5e.se>

This patch no longer applies cleanly after this patch that was just merged.



commit 940a96e6ca9a14cd52c97a719a1700b417adb2fb
Author: Phil Sutter <phil@nwl.cc>
Date:   Mon Sep 21 21:33:01 2015 +0200

    ip-link: do not support 'ip link add dev help'
    
    Commit 0532555 ('Support "ip link add help" for rtnl_link API') added a
    check for specified help parameter. Though due to the place where it has
    been added to, it is not possible anymore to force a given parameter to
    be interpreted as interface name by prefixing it with 'dev '. Fix this
    by forcing whatever follows 'dev' to be presumed as interface name.
    
    Signed-off-by: Phil Sutter <phil@nwl.cc>

      parent reply	other threads:[~2015-09-23 23:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-18  8:23 [PATCH] ip: allow using a device "help" (or a prefix thereof) Christoph Schulz
2015-09-18 12:06 ` Erik Hugne
2015-09-23 23:07 ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150923160702.08b62a84@urahara \
    --to=stephen@networkplumber.org \
    --cc=develop@kristov.de \
    --cc=leonhard@pre.is \
    --cc=lists@0x5e.se \
    --cc=netdev@vger.kernel.org \
    --cc=vadim4j@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.