Re: [Qemu-devel] [RFC PATCH 09/14] vfio: Expose a VFIO PCI device's group for EEH

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1443 bytes --]

On Wed, Sep 23, 2015 at 11:28:43AM -0600, Alex Williamson wrote:
> On Sat, 2015-09-19 at 17:18 +1000, David Gibson wrote:
> > The Enhanced Error Handling (EEH) interface in PAPR operates on units of a
> > Partitionable Endpoint (PE).  For VFIO devices, the PE boundaries the guest
> > sees must match the PE (i.e. IOMMU group) boundaries on the host.  To
> > implement this VFIO needs to expose to EEH the IOMMU group each VFIO device
> > belongs to.
> > 
> > Add a vfio_pci_device_group() function to the VFIO/EEH interface for this
> > purpose.
> > 
> > Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> > ---
> >  hw/vfio/pci.c              | 13 +++++++++++++
> >  include/hw/vfio/vfio-eeh.h |  1 +
> >  2 files changed, 14 insertions(+)
> > 
> > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
> > index 73d34b9..29f9467 100644
> > --- a/hw/vfio/pci.c
> > +++ b/hw/vfio/pci.c
> > @@ -41,6 +41,7 @@
> >  #include "trace.h"
> >  #include "hw/vfio/vfio.h"
> >  #include "hw/vfio/vfio-common.h"
> > +#include "hw/vfio/vfio-eeh.h"
> 
> 
> Why?  EEH may be the consumer, but it's not EEH specific, it should not
> have the prototype in an EEH specific header.

Ok, planning to create a vfio-pci.h in the respin.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]