All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Punit Vara <punitvara@gmail.com>
Cc: Larry.Finger@lwfinger.net, devel@driverdev.osuosl.org,
	florian.c.schilhabel@googlemail.com,
	linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings fix for block comment
Date: Thu, 24 Sep 2015 12:00:01 +0300	[thread overview]
Message-ID: <20150924090001.GK4953@mwanda> (raw)
In-Reply-To: <1443039862-6197-1-git-send-email-punitvara@gmail.com>

On Thu, Sep 24, 2015 at 01:54:22AM +0530, Punit Vara wrote:
> This is a patch to the rtl871x_mp.h that fixes up following warnings
> reported by checkpatch.pl :
> 
> -Block comments use a trailing */ on a separate line
> 
> Signed-off-by: Punit Vara <punitvara@gmail.com>
> ---
>  drivers/staging/rtl8712/rtl871x_mp.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8712/rtl871x_mp.h b/drivers/staging/rtl8712/rtl871x_mp.h
> index 75893f2..20a4273 100644
> --- a/drivers/staging/rtl8712/rtl871x_mp.h
> +++ b/drivers/staging/rtl8712/rtl871x_mp.h
> @@ -108,7 +108,8 @@ struct mp_priv {
>  	unsigned char network_macaddr[6];
>  	/*Testing Flag*/
>  	u32 mode;/*0 for normal type packet,

This first line is missing some spaces so the whole comment needs to be
redone.

	u32 mode; /* 0 for normal type packet,
		   * 1 for loopback packet (16bytes TXCMD)
		   */

regards,
dan carpenter


  reply	other threads:[~2015-09-24  9:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-23 20:24 [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings fix for block comment Punit Vara
2015-09-24  9:00 ` Dan Carpenter [this message]
2015-09-24 10:27   ` Sudip Mukherjee
2015-09-24 11:22     ` Dan Carpenter
2015-09-24 16:57       ` punit vara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150924090001.GK4953@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=florian.c.schilhabel@googlemail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=punitvara@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.