From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Chen Subject: Re: [RFC PATCH 2/2] usb: phy: Add platform driver support for ULPI PHYs Date: Thu, 24 Sep 2015 17:43:31 +0800 Message-ID: <20150924094330.GC27847@shlinux2> References: <1443012873-13757-1-git-send-email-sbhatta@xilinx.com> <20150924090629.GA27847@shlinux2> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Subbaraya Sundeep Bhatta Cc: "balbi-l0cyMroinI0@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "kishon-l0cyMroinI0@public.gmane.org" , "gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org" , "linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Punnaiah Choudary Kalluri List-Id: devicetree@vger.kernel.org On Thu, Sep 24, 2015 at 09:21:16AM +0000, Subbaraya Sundeep Bhatta wrote: > > > +uphy->flags); > > > + > > > + uphy->usb_phy->set_vbus = usbphy_set_vbus; > > > > When you will call it? > > I am calling it in host.c and otg_fsm.c of Chipidea driver wherever > regulator_enable/disable is called to control VBUS like below: > > if (ci->platdata->flags & CI_HDRC_PHY_VBUS_CONTROL) { > if (enable) > ci->usb_phy->set_vbus(ci->usb_phy, 1); > else > ci->usb_phy->set_vbus(ci->usb_phy, 0); > } > > After these changes host mode and otg modes works fine > for my case. > Get it, there are several vbus control ways, I may need to consolidate them, of cos, this is another topic. -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753378AbbIXJnt (ORCPT ); Thu, 24 Sep 2015 05:43:49 -0400 Received: from mail-by2on0105.outbound.protection.outlook.com ([207.46.100.105]:54721 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753284AbbIXJnq (ORCPT ); Thu, 24 Sep 2015 05:43:46 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; xilinx.com; dkim=none (message not signed) header.d=none;xilinx.com; dmarc=none action=none header.from=freescale.com; Date: Thu, 24 Sep 2015 17:43:31 +0800 From: Peter Chen To: Subbaraya Sundeep Bhatta CC: "balbi@ti.com" , "devicetree@vger.kernel.org" , "kishon@ti.com" , "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Punnaiah Choudary Kalluri" Subject: Re: [RFC PATCH 2/2] usb: phy: Add platform driver support for ULPI PHYs Message-ID: <20150924094330.GC27847@shlinux2> References: <1443012873-13757-1-git-send-email-sbhatta@xilinx.com> <20150924090629.GA27847@shlinux2> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD025;1:IOyP0ChJKX9e4QsfUiNA372O6DCXZhWYLnFloRsvvaV2e+BTH9SSoyTeSQeDyrWlC+QLP3fAiqydYJYR+kqGNgHy8QWCj5rijXa4S9fDI9R4V0FNfTk5h18vgFPddyDDWLAHxLlvjW7XIUuM0hR+cW6LFP1/hV64vViyhH3h2w9QLJoL9tjNULZqwdfkSMBy3YGD9KC4q6BatdIlVh0YeZUFgzM23MUUjphOIuIfLpJawD3MEMyifl+B64PjC+qvumkG8ivuE8urv9+SPuQWeV+zTR8DcUEcmqXgcYgS3D9cBGeBWVI1EbXrxm4O4yfs9IdSYyAGqPRsf61KEJtqn9plsetirvo/3vXIT1MH4wU= X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(979002)(6009001)(2980300002)(1110001)(1109001)(339900001)(24454002)(189002)(199003)(77156002)(33716001)(5007970100001)(92566002)(105606002)(62966003)(11100500001)(106466001)(2950100001)(23726002)(83506001)(68736005)(77096005)(85426001)(110136002)(47776003)(64706001)(86362001)(46406003)(5001960100002)(54356999)(50466002)(6806005)(46102003)(4001540100001)(5001860100001)(97736004)(97756001)(76176999)(5001830100001)(50986999)(33656002)(4001350100001)(104016004)(81156007)(189998001)(87936001)(7059030)(217873001)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM2PR0301MB1280;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DM2PR0301MB1280;2:uzaeTKKH4hDQYGc/DMaBEH/Wi6HRICukTp30mDkSskCU9GrBRz1znrBM0PS0bahJ7PL4EPPOfvUfx8wVXF1uvNdjwfh9tml7q/Hfmnjm2HtZatWWkXz34X1OxsSuu9uxY7YBildzCV+4GbgfiYas7vgnG29fpLM6i1LEOc3nWRA=;3:6l89wEr0gYzp5ZL0X3+wBufgKmAhryLu3beaDTlVKlWPcCjIN0Y1iIiaRJTKjCksjsVblMTiJOxq386qwnKv2e7dvnkarUR+J8+cnmwC3d1dUhGOKK7PEdOm0jRm/+Bw1faXqgnbmP8kOoSCSX9reufwZc9Nv63s5WlyTW7JtXer21EsiIzLx1KIoCDpcSfM1oD2HlkousijKPnHaBfX3lMucSd6374Il8ss/pzsaXQ=;25:iFXruJMmWzNrIYxtCa38K+utpmpYf1udMR4D1lpf578ZOCn3xqA3NoCVsdhLbfpkLrHJY9CVRYKcxwoH3mBA78hoifWXhZ6u/pqoDc11zxehx0hSR4CmBt/HUKjI9RM+a2MYUOqS2GViF4qvmoY6ZOaHVoH7YCjQ47yxm7N2K0KUoRljmv8TNMIWfPQSDfds0gWubejJ7s8BWDGO+LA+ewixgX6bawAIZgkVuoiSAeDWLcB2ssoWdWGm0NPeWqHsOwRBIgRZB7Qcjn3fXU/s0A== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0301MB1280; X-Microsoft-Exchange-Diagnostics: 1;DM2PR0301MB1280;20:Jy6URdfVyaH/PfZLd+lyztwYxtaXjEukwUOWiLdC/CfOFrHMZ+kdBgIOamckyDHiUZvqIZwhEqS0NOOzL3Cj0Yk2Tra7nr/m/HvtBzoyYc7oQFK177zeDpjYIUOUOFwBKw6Fr7kBKGI/hCvXJiXM4MF771x9eRtnSWTeOlDhsgj4BFjQA5WWaegO5698i/4kMX3chZi1RMTCRedHF+uAFWxeVQwQL3EQfdSk9HzHWX8y8grWC4Jl1VFiAYT76R8ksh5leQrBjZ2i1KLOs9h5cD3htVDZHdFyBS7q2/hY06+hQc3ws+zpslkdJXmLNaeCpzdcQ507F+h8qI7a2uK6cQsr8C0VDt1lon5xn32e2VI=;4:aO4s018nEq+qvlDTGEmExT6yfACizk4cJ1haSGQlGwftHYjS6qzp5LPEw5wEMgst4HcVLIn0EIovMZrTqGRAMbigMtDEuwPaovsQqU0+zTmKD0OBLE//G25+79jnnwFexRxerkUTvYahzFu8FtLmJYPZvcnJfrt0eMnAHKTod+IFgZyTOnZw2Rhp8dPX35HO+NYEbFd9yVJJin1UyuxdpNzcxfB5mbVbQLxI66F1LGif27Ruy7z4n1hmu/i2qAXfMBTKPH6yifJWw+ZJDMQq9KkSQkAeH6kcRhNc43FPYckv5fMXFCCj/eHOHSmF1JMgXocsGA6wvpFPJG1VF/glXXzHZYulGm+eVinh81Ht7P4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(3002001);SRVR:DM2PR0301MB1280;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0301MB1280; X-Forefront-PRVS: 070912876F X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM2PR0301MB1280;23:bMgCUMDM+lxZDUJpERVGArjW+oPNOt0biA3bK5E?= =?us-ascii?Q?p7Q0DvCV8Cxv4FjY9sQozk7YEnof+DqTm9cpZ6NBjQ9HrzVXuyHSEMKrXGg+?= =?us-ascii?Q?ThWaeR/KYgYtX5qF8fyPmaYgo4UXiID73AmNwaUiN6N4GIWR/P9W4Sv3r8yV?= =?us-ascii?Q?kbHIOJuM3Ve/L8kpn1jH3oeSJQbsCtbQWhXBauFu9ldKvADepYA9DBuOjA6u?= =?us-ascii?Q?AOfi1Q136I95mYtJh2SHZWijrA27gTKvJDCEoOBanP3cEe+qgA7x6ss08WDC?= =?us-ascii?Q?KvZ4JXbrQWIWdtL4OFtly/ZzcXqg2m2dToUJHl1sKeyIOz+WSJaQ3xEx0XXL?= =?us-ascii?Q?VbBdB14St9SAGIU5YjEeDMqROzV9x+qwoOSBk+CVSLq5Un/BVHRyTzsUkQzG?= =?us-ascii?Q?7Z59utedb7W4FP7nO6IIEtVMFS3BEmizLlbYLzRlqTwziITR1tO1+hGgg+8Z?= =?us-ascii?Q?+dgRTZTGY9UG+gfp+Pus1HndyNcT5vfa6RZs4ibHYYGfZcq9m+Scw+1EiPtj?= =?us-ascii?Q?csfD24+p7FKYxqfb8nj9pGPpSoiUBspiGtvhnObsTeYB3dczWwR+phPNUolL?= =?us-ascii?Q?h4vA1Gl5A7mQOp3vEploGhXSt3K5ktzd9de0ksW4qbf3Q4/HUpxJx7lK67k5?= =?us-ascii?Q?XeXgRhIm5f8Dyy6C4wYYB07WxkDSY/hXocw2gvB3jLFYXPXWThOraWSDLGTJ?= =?us-ascii?Q?4xA18bjemAijeeqZqzmhjfak0rN1pQL5OwePd9R/b2nAYlaFv78mEHIePv8I?= =?us-ascii?Q?u7yJwrDAR3jdCGgImi/Ut6U5rF0zjeqY1j2Z/2Hqc6KTGB3Ng733RaUx3JlK?= =?us-ascii?Q?wabFWMxyUL/a4tCkYY0kAE7TK1H7x9bHzS3UcHmhw96YujTXl4yyYlPuFobk?= =?us-ascii?Q?bO5ncdAEJbjnRie3V25CMaYh8z77FB6ScW2R9MEKfSo2BUFJwc9xqWQeAK02?= =?us-ascii?Q?MjxlJJ7Tj5ErvQ1+3mZlznbnkVavU9zKo2te9BpZ89xMymG/CWJqmaLezC94?= =?us-ascii?Q?1IDjFaktFE/zZ9ZR3pwX5irwIJ8wThGswhYDWzT01RLrmarQwBmb4KXFoY0Z?= =?us-ascii?Q?+BGpyJkt9bQVNtGbr10E0bFydvYzIEGNgcSC+ckwvA8eoy0Iqq84Ime53SVR?= =?us-ascii?Q?HQllI5PnYeYGsono+m3p2+vkUBPJFO/8lPjQ1Ad9DuUuxuwERpZzVaust9mN?= =?us-ascii?Q?K9DFW/wEb1gP2o3N0QQCLtUbV7HHUhh5zmT/rTESrGnYIu4YukFDHwYlvpjO?= =?us-ascii?Q?l3Vx6iOU5iT5TFKBWT2KWimHzik4hRpMpu9CviV59l8K0SWvzFA9psfZM1O4?= =?us-ascii?Q?qFiOtRPKnyh2TSVH2M2UHJEboEONfkIsD81NZ0PlALlBg?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR0301MB1280;5:fBZqdYZT20D66HXFrL8Igz53ARc4WEE386dNuV071hupPPZMI1cVXcpCbincxvfamVLo1zxXMw/j+65SjiYKfaXjovICX3qDGy0g/isGeEnr1V2BMzeWdHhylBpYlaDF3GP+9eO/yonrdma+/qN7CA==;24:M5j1nCHshFOTyX4UFImE+xWXKqGk9juw4N1GVvEyc3fY7DENA6MSrQYadccJolKpjQoX0P6ndn5GaZQ0o/yA6YV3P1qGKugK00g9+99ABz8=;20:BO56jzV95ghwUV5CVzS2P4JG5coNSXtwVKVl0FM1j9Ou9FntXuG2zi8On6Pny0YFO+0+9UQZheW3VygIyLvlRA== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2015 09:43:44.3158 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB1280 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 24, 2015 at 09:21:16AM +0000, Subbaraya Sundeep Bhatta wrote: > > > +uphy->flags); > > > + > > > + uphy->usb_phy->set_vbus = usbphy_set_vbus; > > > > When you will call it? > > I am calling it in host.c and otg_fsm.c of Chipidea driver wherever > regulator_enable/disable is called to control VBUS like below: > > if (ci->platdata->flags & CI_HDRC_PHY_VBUS_CONTROL) { > if (enable) > ci->usb_phy->set_vbus(ci->usb_phy, 1); > else > ci->usb_phy->set_vbus(ci->usb_phy, 0); > } > > After these changes host mode and otg modes works fine > for my case. > Get it, there are several vbus control ways, I may need to consolidate them, of cos, this is another topic. -- Best Regards, Peter Chen