From: Stephen Hemminger <stephen@networkplumber.org>
To: Yuval Mintz <Yuval.Mintz@qlogic.com>
Cc: <netdev@vger.kernel.org>, <Ariel.Elior@qlogic.com>,
Sudarsana Kalluru <Sudarsana.Kalluru@qlogic.com>
Subject: Re: [RFC v2 net-next 05/10] qede: Add basic network device support
Date: Thu, 24 Sep 2015 14:25:36 -0700 [thread overview]
Message-ID: <20150924142536.052d6175@urahara> (raw)
In-Reply-To: <1442499839-22762-6-git-send-email-Yuval.Mintz@qlogic.com>
On Thu, 17 Sep 2015 17:23:54 +0300
Yuval Mintz <Yuval.Mintz@qlogic.com> wrote:
> +#define QEDE_NAPI_WEIGHT (NAPI_POLL_WEIGHT)
> +
Why not just use existing constant rather than walpapering?
> +
> +#define U64_LO(x) ((u32)(((u64)(x)) & 0xffffffff))
> +#define U64_HI(x) ((u32)(((u64)(x)) >> 32))
> +#define HILO_U64(hi, lo) ((((u64)(hi)) << 32) + (lo))
Why reinvent upper32 and lower32?
> +struct qede_rx_queue {
> + __le16 *hw_cons_ptr;
The __ variants of constants should be reserved for use in user visible
API's
> + struct sw_rx_data *sw_rx_ring;
> + u16 sw_rx_cons;
> + u16 sw_rx_prod;
> + struct qed_chain rx_bd_ring;
> + struct qed_chain rx_comp_ring;
> + void __iomem *hw_rxq_prod_addr;
> +
> + int rx_buf_size;
Shouldn't rx_buf_size be unsigned?
next prev parent reply other threads:[~2015-09-24 21:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 14:23 [RFC v2 net-next 00/10] Add new drivers: qed & qede Yuval Mintz
2015-09-17 14:23 ` [RFC v2 net-next 01/10] qed: Add module with basic common support Yuval Mintz
2015-09-17 14:23 ` [RFC v2 net-next 02/10] qed: Add basic L2 interface Yuval Mintz
2015-09-17 14:23 ` [RFC v2 net-next 03/10] qede: Add basic Network driver Yuval Mintz
2015-09-17 14:23 ` [RFC v2 net-next 04/10] qed: Add slowpath L2 support Yuval Mintz
2015-09-17 14:23 ` [RFC v2 net-next 05/10] qede: Add basic network device support Yuval Mintz
2015-09-24 21:25 ` Stephen Hemminger [this message]
2015-09-25 5:43 ` Yuval Mintz
2015-09-25 5:56 ` David Miller
2015-09-25 6:02 ` Yuval Mintz
2015-09-29 7:54 ` Yuval Mintz
2015-09-17 14:23 ` [RFC v2 net-next 06/10] qede: classification configuration Yuval Mintz
2015-09-17 14:23 ` [RFC v2 net-next 07/10] qed: Add link support Yuval Mintz
2015-09-17 14:23 ` [RFC v2 net-next 08/10] qede: Add support for link Yuval Mintz
2015-09-17 14:23 ` [RFC v2 net-next 09/10] qed: Add statistics support Yuval Mintz
2015-09-17 14:23 ` [RFC v2 net-next 10/10] qede: Add basic ethtool support Yuval Mintz
2015-09-24 14:46 ` [RFC v2 net-next 00/10] Add new drivers: qed & qede Ariel Elior
2015-09-24 17:58 ` David Miller
2015-09-24 18:10 ` Yuval Mintz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150924142536.052d6175@urahara \
--to=stephen@networkplumber.org \
--cc=Ariel.Elior@qlogic.com \
--cc=Sudarsana.Kalluru@qlogic.com \
--cc=Yuval.Mintz@qlogic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.