From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudip Mukherjee Subject: Re: [PATCH] drm/mgag200: fix memory leak Date: Thu, 24 Sep 2015 21:23:09 +0530 Message-ID: <20150924155309.GD10109@sudip-pc> References: <1441627110-13783-1-git-send-email-sudipm.mukherjee@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) by gabe.freedesktop.org (Postfix) with ESMTPS id E00B56E0C9 for ; Thu, 24 Sep 2015 08:53:15 -0700 (PDT) Received: by padhy16 with SMTP id hy16so76687655pad.1 for ; Thu, 24 Sep 2015 08:53:15 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1441627110-13783-1-git-send-email-sudipm.mukherjee@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David Airlie , Daniel Vetter , Thierry Reding Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBTZXAgMDcsIDIwMTUgYXQgMDU6Mjg6MzBQTSArMDUzMCwgU3VkaXAgTXVraGVyamVl IHdyb3RlOgo+IElmIGRybV9mYl9oZWxwZXJfYWxsb2NfZmJpKCkgZmFpbHMgdGhlbiB3ZSB3ZXJl IGRpcmVjdGx5IHJldHVybmluZwo+IHdpdGhvdXQgZnJlZWluZyBzeXNyYW0uIEFsc28gaWYgZHJt X2ZiX2hlbHBlcl9hbGxvY19mYmkoKSBzdWNjZWVkcyBidXQKPiBtZ2FnMjAwX2ZyYW1lYnVmZmVy X2luaXQoKSBmYWlscyB0aGVuIHdlIHdlcmUgbm90IHJlbGVhc2luZyBzeXNyYW0gYW5kCj4gd2Ug d2VyZSBub3QgcmVsZWFzaW5nIGZiaSBoZWxwZXIgYWxzby4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBT dWRpcCBNdWtoZXJqZWUgPHN1ZGlwQHZlY3RvcmluZGlhLm9yZz4KPiAtLS0KSGkgVGhpZXJyeSwK QSBnZW50bGUgcGluZy4KCnJlZ2FyZHMKc3VkaXAKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756974AbbIXPxR (ORCPT ); Thu, 24 Sep 2015 11:53:17 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:35682 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753970AbbIXPxQ (ORCPT ); Thu, 24 Sep 2015 11:53:16 -0400 Date: Thu, 24 Sep 2015 21:23:09 +0530 From: Sudip Mukherjee To: David Airlie , Daniel Vetter , Thierry Reding Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/mgag200: fix memory leak Message-ID: <20150924155309.GD10109@sudip-pc> References: <1441627110-13783-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441627110-13783-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 07, 2015 at 05:28:30PM +0530, Sudip Mukherjee wrote: > If drm_fb_helper_alloc_fbi() fails then we were directly returning > without freeing sysram. Also if drm_fb_helper_alloc_fbi() succeeds but > mgag200_framebuffer_init() fails then we were not releasing sysram and > we were not releasing fbi helper also. > > Signed-off-by: Sudip Mukherjee > --- Hi Thierry, A gentle ping. regards sudip