From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudip Mukherjee Subject: Re: [PATCH] drm/gma500: fix double freeing Date: Thu, 24 Sep 2015 21:27:25 +0530 Message-ID: <20150924155725.GE10109@sudip-pc> References: <1441803040-15998-1-git-send-email-sudipm.mukherjee@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com [209.85.220.47]) by gabe.freedesktop.org (Postfix) with ESMTPS id CC5296EEEF for ; Thu, 24 Sep 2015 08:57:30 -0700 (PDT) Received: by pacex6 with SMTP id ex6so76648582pac.0 for ; Thu, 24 Sep 2015 08:57:30 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1441803040-15998-1-git-send-email-sudipm.mukherjee@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David Airlie , Daniel Vetter , Patrik Jakobsson Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBTZXAgMDksIDIwMTUgYXQgMDY6MjA6NDBQTSArMDUzMCwgU3VkaXAgTXVraGVyamVl IHdyb3RlOgo+IElmIGJhY2tpbmctPnN0b2xlbiBpcyB0cnVlIHRoZW4gd2Ugd2VyZSBmcmVlaW5n IGJhY2tpbmcgYnkgY2FsbGluZwo+IHBzYl9ndHRfZnJlZV9yYW5nZSgpIGJ1dCB3ZSBjYWxsZWQg aXQgYWdhaW4gYWZ0ZXIgdW5sb2NraW5nIHRoZSBtdXRleC4KPiBMZXRzIG1ha2UgaXQgTlVMTCBh ZnRlciBmcmVlaW5nIGluIHBzYl9ndHRfZnJlZV9yYW5nZSgpIGFuZCBjaGVjayBmb3IKPiBOVUxM IGJlZm9yZSBjYWxsaW5nIHRoZSBmdW5jdGlvbiBmb3IgdGhlIHNlY29uZCB0aW1lLgo+IAo+IFNp Z25lZC1vZmYtYnk6IFN1ZGlwIE11a2hlcmplZSA8c3VkaXBAdmVjdG9yaW5kaWEub3JnPgo+IC0t LQpIaSBQYXRyaWssCkEgZ2VudGxlIHBpbmcuCgpyZWdhcmRzCnN1ZGlwCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757010AbbIXP5c (ORCPT ); Thu, 24 Sep 2015 11:57:32 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:35369 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754047AbbIXP5b (ORCPT ); Thu, 24 Sep 2015 11:57:31 -0400 Date: Thu, 24 Sep 2015 21:27:25 +0530 From: Sudip Mukherjee To: David Airlie , Daniel Vetter , Patrik Jakobsson Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/gma500: fix double freeing Message-ID: <20150924155725.GE10109@sudip-pc> References: <1441803040-15998-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441803040-15998-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 09, 2015 at 06:20:40PM +0530, Sudip Mukherjee wrote: > If backing->stolen is true then we were freeing backing by calling > psb_gtt_free_range() but we called it again after unlocking the mutex. > Lets make it NULL after freeing in psb_gtt_free_range() and check for > NULL before calling the function for the second time. > > Signed-off-by: Sudip Mukherjee > --- Hi Patrik, A gentle ping. regards sudip