From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vivien Didelot Subject: Re: [PATCH net-next] net: dsa: Set a "dsa" device_type Date: Thu, 24 Sep 2015 23:37:26 -0400 Message-ID: <20150925033725.GA18915@ketchup.lan> References: <1443057598-25729-1-git-send-email-f.fainelli@gmail.com> <20150924223748.GA6064@ketchup.mtl.sfl> <5604954A.7090409@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, linux@roeck-us.net, andrew@lunn.ch To: Florian Fainelli Return-path: Received: from ip-208-88-110-44.savoirfairelinux.net ([208.88.110.44]:54710 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753503AbbIYDhb (ORCPT ); Thu, 24 Sep 2015 23:37:31 -0400 Content-Disposition: inline In-Reply-To: <5604954A.7090409@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Sep. Thursday 24 (39) 05:28 PM, Florian Fainelli wrote: > On 24/09/15 15:37, Vivien Didelot wrote: > > Hi Florian, > > > > On Sep. Wednesday 23 (39) 06:19 PM, Florian Fainelli wrote: > >> Provide a device_type information for slave network devices created by > >> DSA, this is useful for user-space application to easily locate/search > >> for devices of a specific kind. > >> > >> Signed-off-by: Florian Fainelli Reviewed-by: Vivien Didelot > > > > Noob question, how is that used from user-space? > > This changes the 'uevent' attribute, before, it would look like this: > > cat /sys/class/net/gphy/uevent > OF_NAME=port > OF_FULLNAME=/rdb/switch_top@f0b00000/ethernet_switch@0/switch@0/port@0 > OF_COMPATIBLE_N=0 > OF_ALIAS_0=switch_port0 > INTERFACE=gphy > IFINDEX=3 > # > > With that change it looks like this: > > # cat /sys/class/net/gphy/uevent > DEVTYPE=dsa > OF_NAME=port > OF_FULLNAME=/rdb/switch_top@f0b00000/ethernet_switch@0/switch@0/port@0 > OF_COMPATIBLE_N=0 > OF_ALIAS_0=switch_port0 > INTERFACE=gphy > IFINDEX=3 > > VLAN does a similar thing: > > DEVTYPE=vlan > INTERFACE=eth0.2 > IFINDEX=14 > > > > > Also, don't you think that this "dsa" device type might be conflicting > > with eventually exposed DSA ports? Or will they all get the same type? > > Well, as of today these ports are not exposed, it is unclear to me > whether they would be real network devices (with an actual struct device > backing them), and we may want to dedicate a specific DEVTYPE like > "dsa-pseudo-port" or something like that, specifically for these devices. > > Hope this clarifies the intent and usefulness of the patch. Yes it does, thanks! I don't have the usage for this (yet?) but it looks good anyway. I hope it's ok to put the Reviewed-by: tag here, otherwise I'll reply to the first message. -v