diff for duplicates of <20150925113429.GF27119@pali> diff --git a/a/1.txt b/N1/1.txt index 4293647..9b17f5d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,8 +1,8 @@ On Thursday 17 September 2015 07:16:44 Pavel Machek wrote: > -> > > if (image->depth = 1) { -> > > if (p->fix.visual = FB_VISUAL_TRUECOLOR || -> > > p->fix.visual = FB_VISUAL_DIRECTCOLOR) { +> > > if (image->depth == 1) { +> > > if (p->fix.visual == FB_VISUAL_TRUECOLOR || +> > > p->fix.visual == FB_VISUAL_DIRECTCOLOR) { > > > fgcolor = ((u32*)(p->pseudo_palette))[image->fg_color]; > > > bgcolor = ((u32*)(p->pseudo_palette))[image->bg_color]; > > > } else { @@ -10,8 +10,8 @@ On Thursday 17 September 2015 07:16:44 Pavel Machek wrote: > > > bgcolor = image->bg_color; > > > } > > > -> > > if (32 % bpp = 0 && !start_index && !pitch_index && -> > > ((width & (32/bpp-1)) = 0) && +> > > if (32 % bpp == 0 && !start_index && !pitch_index && +> > > ((width & (32/bpp-1)) == 0) && > > > bpp >= 8 && bpp <= 32) > > > fast_imageblit(image, p, dst1, fgcolor, bgcolor); > > > else @@ -21,7 +21,7 @@ On Thursday 17 September 2015 07:16:44 Pavel Machek wrote: > > > color_imageblit(image, p, dst1, start_index, pitch_i > > > > > > -> > > Notice that bpp is not checked for zero, and thus bpp=0 is totally +> > > Notice that bpp is not checked for zero, and thus bpp==0 is totally > > > feasible? resulting in 32/bpp crashing the kernel? > > > > > @@ -31,7 +31,7 @@ On Thursday 17 September 2015 07:16:44 Pavel Machek wrote: > > And is there some way to force kernel to dump backtrace into dmesg when > > division by zero occur? > -> You can do WARN_ON(bpp=1) ... and should probably return in that +> You can do WARN_ON(bpp==1) ... and should probably return in that > case. > > Pavel @@ -40,5 +40,5 @@ Does not make sense to call slow_ function? In that if condition check also that bpp is nonzero... -- -Pali Rohár +Pali Rohár pali.rohar@gmail.com diff --git a/a/content_digest b/N1/content_digest index 23a22d5..4ef0991 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,7 +4,7 @@ "ref\020150917051644.GA6665@amd\0" "From\0Pali Roh\303\241r <pali.rohar@gmail.com>\0" "Subject\0Re: omapdss: Division by zero in kernel\0" - "Date\0Fri, 25 Sep 2015 11:34:29 +0000\0" + "Date\0Fri, 25 Sep 2015 13:34:29 +0200\0" "To\0Pavel Machek <pavel@ucw.cz>\0" "Cc\0Peter Teoh <htmldeveloper@gmail.com>" Tomi Valkeinen <tomi.valkeinen@ti.com> @@ -21,9 +21,9 @@ "b\0" "On Thursday 17 September 2015 07:16:44 Pavel Machek wrote:\n" "> \n" - "> > > if (image->depth = 1) {\n" - "> > > if (p->fix.visual = FB_VISUAL_TRUECOLOR ||\n" - "> > > p->fix.visual = FB_VISUAL_DIRECTCOLOR) {\n" + "> > > if (image->depth == 1) {\n" + "> > > if (p->fix.visual == FB_VISUAL_TRUECOLOR ||\n" + "> > > p->fix.visual == FB_VISUAL_DIRECTCOLOR) {\n" "> > > fgcolor = ((u32*)(p->pseudo_palette))[image->fg_color];\n" "> > > bgcolor = ((u32*)(p->pseudo_palette))[image->bg_color];\n" "> > > } else {\n" @@ -31,8 +31,8 @@ "> > > bgcolor = image->bg_color;\n" "> > > }\n" "> > > \n" - "> > > if (32 % bpp = 0 && !start_index && !pitch_index &&\n" - "> > > ((width & (32/bpp-1)) = 0) &&\n" + "> > > if (32 % bpp == 0 && !start_index && !pitch_index &&\n" + "> > > ((width & (32/bpp-1)) == 0) &&\n" "> > > bpp >= 8 && bpp <= 32)\n" "> > > fast_imageblit(image, p, dst1, fgcolor, bgcolor);\n" "> > > else\n" @@ -42,7 +42,7 @@ "> > > color_imageblit(image, p, dst1, start_index, pitch_i\n" "> > > \n" "> > > \n" - "> > > Notice that bpp is not checked for zero, and thus bpp=0 is totally\n" + "> > > Notice that bpp is not checked for zero, and thus bpp==0 is totally\n" "> > > feasible? resulting in 32/bpp crashing the kernel?\n" "> > > \n" "> > \n" @@ -52,7 +52,7 @@ "> > And is there some way to force kernel to dump backtrace into dmesg when\n" "> > division by zero occur?\n" "> \n" - "> You can do WARN_ON(bpp=1) ... and should probably return in that\n" + "> You can do WARN_ON(bpp==1) ... and should probably return in that\n" "> case.\n" "> \n" "> \t\t\t\t\t\t\t\tPavel\n" @@ -61,7 +61,7 @@ "also that bpp is nonzero...\n" "\n" "-- \n" - "Pali Roh\303\203\302\241r\n" + "Pali Roh\303\241r\n" pali.rohar@gmail.com -66d6ef6767be159dde6308cedb94b1be85268b0abacebd372532dc86b0758c93 +782fca30361e5499a3a7a5a87d44d61201755ff5fb64be50e14de40a3019e96f
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.