All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: mingo@kernel.org
Cc: linux-kernel@vger.kernel.org, msalter@redhat.com,
	linux@roeck-us.net, oleg@redhat.com, sasha.levin@oracle.com
Subject: [GIT PULL rcu/urgent] Fix two more 4.3 regressions
Date: Sat, 26 Sep 2015 21:19:30 -0700	[thread overview]
Message-ID: <20150927041930.GA32426@linux.vnet.ibm.com> (raw)

Hello, Ingo,

This series contains two small fixes for regressions introduced during
the past merge window:

1.	Recent versions of gcc are fatally confused by use of a const
	int variable for array bounds in inline functions, one of which
	was introduced by 114b7fd4b (rcu: Create rcu_sync infrastructure).
	For more information on the gcc bug, see:

		https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67055#c13

	This workaround for that gcc bug, courtesy of Oleg Nesterov,
	simply substitutes the constant expression for the two uses of
	the const int variable.

2.	Commit 2cd6ffafec06 (rcu: Extend expedited funnel locking
	to rcu_data structure) extended contention-reducing
	funnel locking from the rcu_node structures to the rcu_data
	structures, but failed to create a separate lock class for the
	rcu_sched_data structures, which is needed due to the fact that
	synchronize_rcu_expedited() invokes synchronize_sched_expedited().
	In the absence of this separate lock class, lockdep can give
	false-positive splats.	This commit therefore creates the
	required lock class so that lockdep can see that there is in
	fact no deadlock.

Both fixes have been exposed to -next and 0day Test Robot testing.

These changes are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git for-mingo

for you to fetch changes up to 19a5ecde086a6a5287978b12ae948fa691b197b7:

  rcu: Suppress lockdep false positive for rcp->exp_funnel_mutex (2015-09-20 21:01:22 -0700)

----------------------------------------------------------------
Oleg Nesterov (1):
      rcu: Change _wait_rcu_gp() to work around GCC bug 67055

Paul E. McKenney (1):
      rcu: Suppress lockdep false positive for rcp->exp_funnel_mutex

 include/linux/rcupdate.h | 11 +++++------
 kernel/rcu/tree.c        |  5 +++++
 2 files changed, 10 insertions(+), 6 deletions(-)


             reply	other threads:[~2015-09-27  4:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-27  4:19 Paul E. McKenney [this message]
2015-09-28  6:05 ` [GIT PULL rcu/urgent] Fix two more 4.3 regressions Ingo Molnar
  -- strict thread matches above, loose matches on Subject: below --
2015-09-27  6:28 Sedat Dilek
2015-09-27  7:32 ` Paul E. McKenney
2015-09-27  7:37   ` Sedat Dilek
2015-09-27 15:49     ` Paul E. McKenney
2015-09-27 15:55       ` Sedat Dilek
2015-09-27 15:58         ` Sedat Dilek
2015-09-27 16:02           ` Sedat Dilek
2015-09-27 16:16             ` Sedat Dilek
2015-09-27 16:25               ` Sedat Dilek
2015-09-27 16:43                 ` Paul E. McKenney
2015-09-27 16:42         ` Paul E. McKenney
2015-09-27 17:24           ` Sedat Dilek
2015-09-27 17:41             ` Paul E. McKenney
2015-09-28  6:03     ` Ingo Molnar
2015-09-28  6:24       ` Sedat Dilek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150927041930.GA32426@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mingo@kernel.org \
    --cc=msalter@redhat.com \
    --cc=oleg@redhat.com \
    --cc=sasha.levin@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.