From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752737AbbI0U1Z (ORCPT <rfc822;w@1wt.eu>);
	Sun, 27 Sep 2015 16:27:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38697 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750991AbbI0U1Y (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 27 Sep 2015 16:27:24 -0400
Date: Sun, 27 Sep 2015 22:27:15 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: He Kuang <hekuang@huawei.com>
Cc: a.p.zijlstra@chello.nl, mingo@redhat.com, acme@kernel.org,
        jolsa@kernel.org, kan.liang@intel.com, adrian.hunter@intel.com,
        wangnan0@huawei.com, pi3orama@163.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] perf tools: Prompt error message for wrong terms
 of hw/sw events
Message-ID: <20150927202715.GE24007@krava.redhat.com>
References: <1443179511-59238-1-git-send-email-hekuang@huawei.com>
 <1443179511-59238-2-git-send-email-hekuang@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1443179511-59238-2-git-send-email-hekuang@huawei.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 25, 2015 at 11:11:49AM +0000, He Kuang wrote:
> Prompt proper error message when wrong config terms is specificed for
> hw/sw type perf events. This patch makes the original error prompt
> function formats_error_string() more generic, which only outputs the
> static config terms for hw/sw perf events, and prepends pmu formats
> for pmu events.
> 
> Before this patch:
> 
>   $ perf record -e 'cpu-clock/freq=200/' -a sleep 1
>   [ perf record: Woken up 1 times to write data ]
>   [ perf record: Captured and wrote 0.028 MB perf.data (202 samples) ]
> 
>   $ perf record -e 'cpu-clock/freqx=200/' -a sleep 1
>   [ perf record: Woken up 1 times to write data ]
>   [ perf record: Captured and wrote 0.042 MB perf.data (506 samples) ]

this output is not correct at this version,
patch 1/4 will make the above command fail

please change the example accordingly

jirka