From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934088AbbI1QPU (ORCPT <rfc822;w@1wt.eu>);
	Mon, 28 Sep 2015 12:15:20 -0400
Received: from mga09.intel.com ([134.134.136.24]:39667 "EHLO mga09.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S933850AbbI1QPS (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 28 Sep 2015 12:15:18 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.17,603,1437462000"; 
   d="scan'208";a="653732337"
Date: Mon, 28 Sep 2015 09:13:50 -0700
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Pengyu Ma <pengyu.ma@windriver.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>, <rafael.j.wysocki@intel.com>,
        <linux-kernel@vger.kernel.org>, "Box, David E" <david.e.box@intel.com>,
        "Anvin, H Peter" <h.peter.anvin@intel.com>
Subject: Re: [PATCH] powercap / RAPL : remove dependency on iosf_mbi
Message-ID: <20150928091350.50d0243b@icelake>
In-Reply-To: <56061440.1060007@windriver.com>
References: <1442475101-1872-1-git-send-email-pengyu.ma@windriver.com>
	<1542119.JQ7HNYzFZu@vostro.rjw.lan>
	<20150918084356.4bf149a6@yairi>
	<55FF7DFE.8050906@windriver.com>
	<20150921143629.4f597e1c@icelake>
	<5600C6E8.50602@windriver.com>
	<20150922100149.36ae0251@icelake>
	<5603CA74.8010201@windriver.com>
	<20150924093341.744c26d4@icelake>
	<56061440.1060007@windriver.com>
Organization: OTC
X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 26 Sep 2015 11:42:56 +0800
Pengyu Ma <pengyu.ma@windriver.com> wrote:

> $ objdump --dwarf drivers/powercap/intel_rapl.o |grep iosf
>      <65ad>   DW_AT_name        : (indirect string, offset: 0x3644): 
> iosf_mbi_read
>      <65f7>   DW_AT_name        : (indirect string, offset: 0x496): 
> iosf_mbi_write
>    5    3    0    0    iosf_mbi.h
>    0x00000490 656c5f69 6400696f 73665f6d 62695f77 el_id.iosf_mbi_w
>    0x00003640 72656700 696f7366 5f6d6269 5f726561 reg.iosf_mbi_rea
> 
> $ grep -i iosf_mbi .config
> # CONFIG_IOSF_MBI is not set
> 
> It is compiled and included by header file.
> 
Please refer to this table from my earlier email. Pasted below.
 RAPL\IOSF    Y    M    N
>> ___________________________________________________
>>   Y        OK      DC*     Warn on Atom**
>>   M        OK    OK    Warn on Atom
>>   N        OK    OK    OK
>> ___________________________________________________
*DC = don't compile.

The problem is the case when RAPL=y, IOSF=m.

Jacob

> Pengyu
> 
> On 09/25/2015 12:33 AM, Jacob Pan wrote:
> > On Thu, 24 Sep 2015 18:03:32 +0800
> > Pengyu Ma <pengyu.ma@windriver.com> wrote:
> >
> >>> So the problematic case is when RAPL=Y IOSF=M
> >>> Since real IOSF functions are available when
> >>> #if IS_ENABLED(CONFIG_IOSF_MBI)
> >>> There will be no dummy functions for RAPL to reference in this
> >>> case.
> >> iosf_mbi_write/read will warn itself.
> > it does not compile.
> 

[Jacob Pan]