From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ed.bartosh@linux.intel.com>
Received: by yocto-www.yoctoproject.org (Postfix, from userid 118)
	id 4F0CDE00BDC; Mon, 28 Sep 2015 04:17:08 -0700 (PDT)
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
	yocto-www.yoctoproject.org
X-Spam-Level: 
X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI
	autolearn=ham version=3.3.1
X-Spam-HAM-Report: * -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at
	http://www.dnswl.org/, high *      trust
	*      [134.134.136.24 listed in list.dnswl.org]
	* -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
	*      [score: 0.0000]
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
	by yocto-www.yoctoproject.org (Postfix) with ESMTP id 10E79E00349
	for <toaster@yoctoproject.org>; Mon, 28 Sep 2015 04:17:03 -0700 (PDT)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
	by orsmga102.jf.intel.com with ESMTP; 28 Sep 2015 04:17:03 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.17,602,1437462000"; d="scan'208";a="569749883"
Received: from linux.intel.com ([10.23.219.25])
	by FMSMGA003.fm.intel.com with ESMTP; 28 Sep 2015 04:17:02 -0700
Received: from linux.intel.com (vmed.fi.intel.com [10.237.72.51])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by linux.intel.com (Postfix) with ESMTP id 06F156A4083;
	Mon, 28 Sep 2015 04:16:05 -0700 (PDT)
Date: Mon, 28 Sep 2015 14:16:56 +0300
From: Ed Bartosh <ed.bartosh@linux.intel.com>
To: "Smith, Elliot" <elliot.smith@intel.com>
Message-ID: <20150928111656.GA13708@linux.intel.com>
References: <cover.1443430419.git.ed.bartosh@linux.intel.com>
	<09b08571434fed1308a82d9e4865ddf22c676e2c.1443430419.git.ed.bartosh@linux.intel.com>
	<CA+1hgUivUSbtz-46Cg0NB_vcQKGOaai_hHOv-3-o5t-5ksXsjg@mail.gmail.com>
MIME-Version: 1.0
In-Reply-To: <CA+1hgUivUSbtz-46Cg0NB_vcQKGOaai_hHOv-3-o5t-5ksXsjg@mail.gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: toaster@yoctoproject.org
Subject: Re: [PATCH 4/6] toaster: add get_target_objects API
X-BeenThere: toaster@yoctoproject.org
X-Mailman-Version: 2.1.13
Precedence: list
Reply-To: ed.bartosh@linux.intel.com
List-Id: Web based interface for BitBake <toaster.yoctoproject.org>
List-Unsubscribe: <https://lists.yoctoproject.org/options/toaster>,
	<mailto:toaster-request@yoctoproject.org?subject=unsubscribe>
List-Archive: <http://lists.yoctoproject.org/pipermail/toaster>
List-Post: <mailto:toaster@yoctoproject.org>
List-Help: <mailto:toaster-request@yoctoproject.org?subject=help>
List-Subscribe: <https://lists.yoctoproject.org/listinfo/toaster>,
	<mailto:toaster-request@yoctoproject.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Sep 2015 11:17:08 -0000
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Sep 28, 2015 at 10:41:07AM +0100, Smith, Elliot wrote:
> I think we should call this get_or_create_target_objects(), for consistency
> with existing methods, and also to highlight that the method has potential
> database writes as a side effect.
>
yep, agree. I'll send updated patchset for review soon.


--
Regards,
Ed