From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933859AbbI1Ndd (ORCPT ); Mon, 28 Sep 2015 09:33:33 -0400 Received: from mail.kernel.org ([198.145.29.136]:57582 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933439AbbI1Ndb (ORCPT ); Mon, 28 Sep 2015 09:33:31 -0400 Date: Mon, 28 Sep 2015 10:33:32 -0300 From: Arnaldo Carvalho de Melo To: Adrian Hunter Cc: Jiri Olsa , linux-kernel@vger.kernel.org Subject: Re: [PATCH 22/25] perf tools: Add perf_evlist__del() Message-ID: <20150928133332.GB6022@kernel.org> References: <1443186956-18718-1-git-send-email-adrian.hunter@intel.com> <1443186956-18718-23-git-send-email-adrian.hunter@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443186956-18718-23-git-send-email-adrian.hunter@intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Sep 25, 2015 at 04:15:53PM +0300, Adrian Hunter escreveu: > Add a counterpart to perf_evlist__add() that does the opposite > and deletes the evsel. > > This will be used by perf inject to remove unwanted evsels I think perf_evsel__remove() is better, as __del() looks like a shortcut for __delete(), which has different semantics than removing an entry from a list. I'll fix up the patches. - Arnaldo > Signed-off-by: Adrian Hunter > --- > tools/perf/util/evlist.c | 8 ++++++++ > tools/perf/util/evlist.h | 1 + > 2 files changed, 9 insertions(+) > > diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c > index e6760380d731..0bb15e6d12a0 100644 > --- a/tools/perf/util/evlist.c > +++ b/tools/perf/util/evlist.c > @@ -165,6 +165,14 @@ void perf_evlist__add(struct perf_evlist *evlist, struct perf_evsel *entry) > __perf_evlist__propagate_maps(evlist, entry); > } > > +void perf_evlist__del(struct perf_evlist *evlist, struct perf_evsel *evsel) > +{ > + evsel->evlist = NULL; > + list_del_init(&evsel->node); > + evlist->nr_entries -= 1; > + perf_evsel__delete(evsel); > +} > + > void perf_evlist__splice_list_tail(struct perf_evlist *evlist, > struct list_head *list) > { > diff --git a/tools/perf/util/evlist.h b/tools/perf/util/evlist.h > index 0edf0d4f4efa..7fab57d85fa1 100644 > --- a/tools/perf/util/evlist.h > +++ b/tools/perf/util/evlist.h > @@ -73,6 +73,7 @@ void perf_evlist__exit(struct perf_evlist *evlist); > void perf_evlist__delete(struct perf_evlist *evlist); > > void perf_evlist__add(struct perf_evlist *evlist, struct perf_evsel *entry); > +void perf_evlist__del(struct perf_evlist *evlist, struct perf_evsel *evsel); > int perf_evlist__add_default(struct perf_evlist *evlist); > int __perf_evlist__add_default_attrs(struct perf_evlist *evlist, > struct perf_event_attr *attrs, size_t nr_attrs); > -- > 1.9.1