From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com ([66.111.4.27]:51051 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933857AbbI1O0N (ORCPT ); Mon, 28 Sep 2015 10:26:13 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 5492E20748 for ; Mon, 28 Sep 2015 10:26:12 -0400 (EDT) Date: Mon, 28 Sep 2015 07:04:58 -0700 From: Greg KH To: David Miller Cc: luis.henriques@canonical.com, stable@vger.kernel.org Subject: Re: [PATCHES] Networking Message-ID: <20150928140458.GE18915@kroah.com> References: <20150826.230512.911383355891074955.davem@davemloft.net> <20150827133557.GB2433@ares> <20150827.093444.163886036809369260.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150827.093444.163886036809369260.davem@davemloft.net> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Aug 27, 2015 at 09:34:44AM -0700, David Miller wrote: > From: Luis Henriques > Date: Thu, 27 Aug 2015 14:35:57 +0100 > > > Hi David, > > > > On Wed, Aug 26, 2015 at 11:05:12PM -0700, David Miller wrote: > >> > >> Please queue up the following networking bug fixes for v3.12, v3.14, v3.18, > >> and v4.1 -stable, respectively. > >> > >> Thanks! > > > > While going through these patches to pick those applicable to the 3.16 > > kernel, I believe I found an issue with the backport of 1c1bf34951e8 > > ("net/mlx4_core: Fix wrong index in propagating port change event to > > VFs") into 3.14. > > > > The 2nd hunk has the following: > > > > @@ -583,7 +583,7 @@ static int mlx4_eq_int(struct mlx4_dev *dev, struct mlx4_eq *eq) > > for (i = 0; i < dev->num_slaves; i++) { > > if (i == mlx4_master_func_num(dev)) > > continue; > > - s_info = &priv->mfunc.master.vf_oper[slave].vport[port].state; > > + s_info = &priv->mfunc.master.vf_oper[slave].vport[i].state; > > > > It should be: > > > > - s_info = &priv->mfunc.master.vf_oper[slave].vport[port].state; > > + s_info = &priv->mfunc.master.vf_oper[i].vport[port].state; > > > > (the 'slave' index should be changed by 'i', not 'port'). > > Sorry, you are definitely correct. I hope the v3.14 -stable maintain > catches this, thanks! Now fixed, thanks. greg k-h