Re: [PATCH] permutation: Generate permutations of arrays

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1.1: Type: text/plain, Size: 1148 bytes --]

On Sun, Sep 27, 2015 at 04:31:25PM +0930, Paul 'Rusty' Russell wrote:
> David Gibson <david@gibson.dropbear.id.au> writes:
> > + * Example:
> > + *	#include <stdio.h>
> > + *	#include <ccan/permutation/permutation.h>
> > + *
> > + *	int main(int argc, char *argv[])
> > + *	{
> > + *		int i;
> > + *		struct permutation *pi = permutation_new(argc - 1);
> > + *
> > + *		do {
> > + *			for (i = 1; i <= argc; i++)
> > + *				printf("%s ", argv[i]);
> > + *			printf("\n");
> > + *		} while (permutation_change_array(pi,
> > + *		         &argv[1], sizeof(argv[1])));
> > + *		exit(0);
> > + *	}
> 
> That is a masterful example.  It's not quite right though: (i < argc,
> not i <= argc).
> 
> I tried adding:
> 
>  *     // Given 1 2 3 outputs 1 2 3 1 3 2 3 1 2 3 2 1 2 3 1 2 1 3
> 
> But ccanlint isn't clever enough to ignore the \n.
> 
> Let me fix that now...

Fixed those nits and a couple of others, and committed.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
ccan mailing list
ccan@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/ccan