From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753132AbbI1UIP (ORCPT ); Mon, 28 Sep 2015 16:08:15 -0400 Received: from mail.kernel.org ([198.145.29.136]:53011 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751956AbbI1UIN (ORCPT ); Mon, 28 Sep 2015 16:08:13 -0400 Date: Mon, 28 Sep 2015 17:08:10 -0300 From: Arnaldo Carvalho de Melo To: Adrian Hunter Cc: Jiri Olsa , linux-kernel@vger.kernel.org Subject: Re: [PATCH 17/25] perf callchain: Allow for max_stack greater than PERF_MAX_STACK_DEPTH Message-ID: <20150928200810.GC9392@kernel.org> References: <1443186956-18718-1-git-send-email-adrian.hunter@intel.com> <1443186956-18718-18-git-send-email-adrian.hunter@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443186956-18718-18-git-send-email-adrian.hunter@intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Sep 25, 2015 at 04:15:48PM +0300, Adrian Hunter escreveu: > Adjust the validation to allow for max_stack greater than > PERF_MAX_STACK_DEPTH. > > Signed-off-by: Adrian Hunter > --- > tools/perf/util/machine.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c > index fd1efeafb343..d7bd9a304535 100644 > --- a/tools/perf/util/machine.c > +++ b/tools/perf/util/machine.c > @@ -1831,7 +1831,7 @@ static int thread__resolve_callchain_sample(struct thread *thread, > } > > check_calls: > - if (chain->nr > PERF_MAX_STACK_DEPTH) { > + if (chain->nr > PERF_MAX_STACK_DEPTH && (int)chain->nr > max_stack) { Both? > pr_warning("corrupted callchain. skipping...\n"); > return 0; > } > -- > 1.9.1