All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Russell King <linux@arm.linux.org.uk>, linux-pci@vger.kernel.org
Subject: pci_generic_config_write32() access size problem
Date: Mon, 28 Sep 2015 17:08:54 -0500	[thread overview]
Message-ID: <20150928220854.GA16110@localhost> (raw)

Hi Rob,

Russell pointed out a problem with 1f94a94f67e1 ("PCI: Add generic config
accessors").  pci_generic_config_write32() does a read/modify/write if the
size is less than 32 bits, so I think we have problem if this is used with
8- or 16-bit registers that contain RW1C bits.  Any thoughts on how we can
fix this?

Bjorn

             reply	other threads:[~2015-09-28 22:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-28 22:08 Bjorn Helgaas [this message]
2015-09-28 22:42 ` pci_generic_config_write32() access size problem Rob Herring
2015-09-28 23:05   ` Russell King - ARM Linux
2015-09-29 16:47     ` Rob Herring
2015-09-29 17:06       ` Russell King - ARM Linux
     [not found]       ` <CADaLNDndQ6qZ2yuGuff6=cTm565in5e75AjkcX8MJmH2BCwyEw@mail.gmail.com>
2015-09-30 21:30         ` Rob Herring
     [not found]           ` <CADaLNDmjv+SkRxtGDToUTxo4DKFF+yd2LRmte=k4-HRsGOHYVg@mail.gmail.com>
2015-09-30 21:53             ` Rob Herring
2015-10-01  7:46               ` Thierry Reding
2015-10-01 15:45                 ` Ray Jui
2015-10-01 16:11                 ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150928220854.GA16110@localhost \
    --to=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.