From: Brian Norris <computersforpeace@gmail.com>
To: Richard Weinberger <richard@nod.at>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH 1/3] UBI: Fastmap: Simplify expression
Date: Mon, 28 Sep 2015 18:35:44 -0700 [thread overview]
Message-ID: <20150929013544.GX31505@google.com> (raw)
In-Reply-To: <1435912576-27878-1-git-send-email-richard@nod.at>
On Fri, Jul 03, 2015 at 10:36:14AM +0200, Richard Weinberger wrote:
> There is no need to compute pnum again.
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
Acked-by: Brian Norris <computersforpeace@gmail.com>
> ---
> drivers/mtd/ubi/fastmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c
> index 24f2cf6..22db594 100644
> --- a/drivers/mtd/ubi/fastmap.c
> +++ b/drivers/mtd/ubi/fastmap.c
> @@ -775,7 +775,7 @@ static int ubi_attach_fastmap(struct ubi_device *ubi,
> for (j = 0; j < be32_to_cpu(fm_eba->reserved_pebs); j++) {
> int pnum = be32_to_cpu(fm_eba->pnum[j]);
>
> - if ((int)be32_to_cpu(fm_eba->pnum[j]) < 0)
> + if (pnum < 0)
> continue;
>
> aeb = NULL;
> --
> 1.8.4.5
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2015-09-29 1:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 8:36 [PATCH 1/3] UBI: Fastmap: Simplify expression Richard Weinberger
2015-07-03 8:36 ` [PATCH 2/3] UBI: Fix typo in comment Richard Weinberger
2015-09-29 1:36 ` Brian Norris
2015-10-03 18:10 ` Richard Weinberger
2015-07-03 8:36 ` [PATCH 3/3] UBI: Fix debug message Richard Weinberger
2015-09-29 1:35 ` Brian Norris
2015-10-03 18:10 ` Richard Weinberger
2015-09-29 1:35 ` Brian Norris [this message]
2015-10-03 18:09 ` [PATCH 1/3] UBI: Fastmap: Simplify expression Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150929013544.GX31505@google.com \
--to=computersforpeace@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.