From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chandra S Gorentla <csgorentla@gmail.com>
Cc: gregkh@linuxfoundation.org, johnny.kim@atmel.com,
rachel.kim@atmel.com, dean.lee@atmel.com, chris.park@atmel.com,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, sudipm.mukherjee@gmail.com
Subject: Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists
Date: Tue, 29 Sep 2015 05:31:53 +0300 [thread overview]
Message-ID: <20150929023152.GD7289@mwanda> (raw)
In-Reply-To: <1443464037-3591-1-git-send-email-csgorentla@gmail.com>
On Mon, Sep 28, 2015 at 11:43:55PM +0530, Chandra S Gorentla wrote:
> - The message queue is replaced with standard Linux linked list
> - kmem_cache is used for list members
> - A check for return value of receive method is added
> - GFP_ATOMIC is changed to GFP_KERNEL
> - A few other related minor changes
These should be listed and explained.
>
> while (1) {
> - wilc_mq_recv(&gMsgQHostIF, &msg, sizeof(struct host_if_msg), &u32Ret);
> + ret = wilc_mq_recv(&gMsgQHostIF, &msg,
> + sizeof(struct host_if_msg), &u32Ret);
> + if (ret)
> + continue;
> +
I asked before if this was a forever loop and never got a response.
Also what does this have to do with list macros?
regards,
dan carpenter
next prev parent reply other threads:[~2015-09-29 2:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 18:13 [PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists Chandra S Gorentla
2015-09-28 18:13 ` [PATCH 2/2] drivers: staging: wilc1000: wilc_msgqueue.c: Remove code that no effect Chandra S Gorentla
2015-09-28 18:13 ` [PATCH 2/2] drivers: staging: wilc1000: wilc_msgqueue.c: Remove ineffective code Chandra S Gorentla
2015-09-28 18:37 ` [PATCH 2/2] drivers: staging: wilc1000: wilc_msgqueue.c: Remove code that no effect Chandra Gorentla
2015-09-29 0:43 ` Greg KH
2015-09-29 0:44 ` [PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists Greg KH
2015-09-30 12:29 ` Chandra Gorentla
2015-09-29 2:31 ` Dan Carpenter [this message]
2015-09-30 12:42 ` Chandra Gorentla
2015-09-30 13:22 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150929023152.GD7289@mwanda \
--to=dan.carpenter@oracle.com \
--cc=chris.park@atmel.com \
--cc=csgorentla@gmail.com \
--cc=dean.lee@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rachel.kim@atmel.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.