From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Shraddha Barke <shraddha.6596@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 1/2] Staging: gdm724x: gdm_usb.c: Use module_usb_driver
Date: Tue, 29 Sep 2015 10:49:51 +0530 [thread overview]
Message-ID: <20150929051951.GA5935@sudip-pc> (raw)
In-Reply-To: <1443502609-9918-1-git-send-email-shraddha.6596@gmail.com>
On Tue, Sep 29, 2015 at 10:26:48AM +0530, Shraddha Barke wrote:
> Macro module_usb_driver is used for drivers whose init
> and exit paths does only register and unregister.Remove
> boilerplate code by using module_usb_driver.
>
> Problem found using Coccinelle.
>
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
But then how are you going to create the workqueues and
gdm_lte_event_init()?
module_usb_driver() is used in places where the init function is only
having usb_register() and exit function is only having usb_deregister().
If they are doing something special then you can not use
module_usb_driver.
regards
sudip
next prev parent reply other threads:[~2015-09-29 5:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 4:56 [PATCH 1/2] Staging: gdm724x: gdm_usb.c: Use module_usb_driver Shraddha Barke
2015-09-29 4:56 ` [PATCH 2/2] Staging: gdm724x: gdm_mux.c: " Shraddha Barke
2015-09-29 5:19 ` Sudip Mukherjee [this message]
2015-09-29 5:48 ` [Outreachy kernel] [PATCH 1/2] Staging: gdm724x: gdm_usb.c: " Shraddha Barke
2015-09-29 5:40 ` Julia Lawall
2015-09-29 5:55 ` Shraddha Barke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150929051951.GA5935@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=shraddha.6596@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.