From: joeyli <jlee@suse.com>
To: Martin Kepplinger <martink@posteo.de>
Cc: dvhart@infradead.org, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform: acer-wmi: update notice about deprecated user interface
Date: Tue, 29 Sep 2015 17:50:32 +0800 [thread overview]
Message-ID: <20150929095032.GF2115@linux-rxt1.site> (raw)
In-Reply-To: <1443509198-11655-1-git-send-email-martink@posteo.de>
Hi Martin,
On Tue, Sep 29, 2015 at 08:46:38AM +0200, Martin Kepplinger wrote:
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
> ---
> This just looks odd in the logs. Feel free to ignore it or act on it
> differently ;)
>
>
Thanks for your patch and it reminds me to remove those interfaces in acer-wmi.
Please let me check and I am thinking direct remove those interfaces.
Thanks a lot!
Joey Lee
> drivers/platform/x86/acer-wmi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index d773b9d..43d992e 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -1671,7 +1671,7 @@ static ssize_t show_bool_threeg(struct device *dev,
> u32 result; \
> acpi_status status;
>
> - pr_info("This threeg sysfs will be removed in 2014 - used by: %s\n",
> + pr_info("This threeg sysfs will be removed in 2016 - used by: %s\n",
> current->comm);
> status = get_u32(&result, ACER_CAP_THREEG);
> if (ACPI_SUCCESS(status))
> @@ -1684,7 +1684,7 @@ static ssize_t set_bool_threeg(struct device *dev,
> {
> u32 tmp = simple_strtoul(buf, NULL, 10);
> acpi_status status = set_u32(tmp, ACER_CAP_THREEG);
> - pr_info("This threeg sysfs will be removed in 2014 - used by: %s\n",
> + pr_info("This threeg sysfs will be removed in 2016 - used by: %s\n",
> current->comm);
> if (ACPI_FAILURE(status))
> return -EINVAL;
> @@ -1696,7 +1696,7 @@ static DEVICE_ATTR(threeg, S_IRUGO | S_IWUSR, show_bool_threeg,
> static ssize_t show_interface(struct device *dev, struct device_attribute *attr,
> char *buf)
> {
> - pr_info("This interface sysfs will be removed in 2014 - used by: %s\n",
> + pr_info("This interface sysfs will be removed in 2016 - used by: %s\n",
> current->comm);
> switch (interface->type) {
> case ACER_AMW0:
> --
> 2.1.4
>
next prev parent reply other threads:[~2015-09-29 9:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 6:46 [PATCH] platform: acer-wmi: update notice about deprecated user interface Martin Kepplinger
2015-09-29 9:50 ` joeyli [this message]
2015-10-03 17:20 ` Darren Hart
2015-10-05 10:30 ` joeyli
2015-10-05 10:34 ` Martin Kepplinger
2015-10-05 13:04 ` joeyli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150929095032.GF2115@linux-rxt1.site \
--to=jlee@suse.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martink@posteo.de \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.