From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934655AbbI2KmC (ORCPT ); Tue, 29 Sep 2015 06:42:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39161 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934523AbbI2Klw (ORCPT ); Tue, 29 Sep 2015 06:41:52 -0400 Date: Tue, 29 Sep 2015 12:41:47 +0200 From: Jiri Olsa To: He Kuang Cc: Vinson Lee , "H. Peter Anvin" , Thomas Gleixner , Namhyung Kim , David Ahern , Jiri Olsa , Ingo Molnar , Peter Zijlstra , raphael.beamonte@gmail.com, matt@codeblueprint.co.uk, Arnaldo Carvalho de Melo , linux-tip-commits@vger.kernel.org, LKML Subject: Re: [tip:perf/core] tools: Add err.h with ERR_PTR PTR_ERR interface Message-ID: <20150929104147.GD27383@krava.redhat.com> References: <1441615087-13886-2-git-send-email-jolsa@kernel.org> <20150929071410.GA27383@krava.redhat.com> <20150929072028.GB27383@krava.redhat.com> <560A4329.7090100@huawei.com> <20150929075717.GC27383@krava.redhat.com> <560A48AB.7040907@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <560A48AB.7040907@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 29, 2015 at 04:15:39PM +0800, He Kuang wrote: > > > On 2015/9/29 15:57, Jiri Olsa wrote: > >On Tue, Sep 29, 2015 at 03:52:09PM +0800, He Kuang wrote: > >>hi, jirka > >> > >>On 2015/9/29 15:20, Jiri Olsa wrote: > >>>On Tue, Sep 29, 2015 at 09:14:10AM +0200, Jiri Olsa wrote: > >>> > >>>SNIP > >>> > >>>>>>$ gcc --version > >>>>>>gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-16) > >>>>>>Copyright (C) 2010 Free Software Foundation, Inc. > >>>>>>This is free software; see the source for copying conditions. There is NO > >>>>>>warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. > >>>>>> > >>>>>>Cheers, > >>>>>>Vinson > >>>>> > >>>>>Hi. > >>>>> > >>>>>This build error still occurs with next-20150929. > >>>> > >>>>attached patch should fix it > >>>> > >>>>FYI there's another instance of this bug in parse-events.c in > >>>>Arnaldo's perf/core due to recent fixes, I'll send out fix shortly > >>> > >>>and here it is.. > >>> > >>>He Kuang, > >>>this might collide with your recent fixes.. > >>> > >> > >>Do I need to send new ones based on your patch below now? > > > >that'd be great.. also please make sure you don't reintroduce it > > > > I saw Ingo just accepted ACME's pull request which contains my patches, > then resend may reintroduce or conflict things, I will wait for ACME's > suggestion for my lack of experience in this. hum, I can see your changes in pull request to Ingo, but not in acme's perf/core.. strange.. let's wait for Arnaldo to sort it out ;-) thanks, jirka