All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shivani Bhardwaj <shivanib134@gmail.com>
To: outreachy-kernel@googlegroups.com
Subject: [PATCH] Drivers: clk: clk-mux: fixed line exceeding char limit and irrelevant messages
Date: Wed, 30 Sep 2015 02:23:25 +0530	[thread overview]
Message-ID: <20150929205325.GA10085@ubuntu> (raw)

Fixed warnings about line exceeding 80 characters and unnecessary error print
statements.

Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
---
 drivers/clk/clk-mux.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/drivers/clk/clk-mux.c b/drivers/clk/clk-mux.c
index 7129c86..2ef8eda 100644
--- a/drivers/clk/clk-mux.c
+++ b/drivers/clk/clk-mux.c
@@ -35,12 +35,13 @@ static u8 clk_mux_get_parent(struct clk_hw *hw)
 	u32 val;
 
 	/*
-	 * FIXME need a mux-specific flag to determine if val is bitwise or numeric
-	 * e.g. sys_clkin_ck's clksel field is 3 bits wide, but ranges from 0x1
-	 * to 0x7 (index starts at one)
-	 * OTOH, pmd_trace_clk_mux_ck uses a separate bit for each clock, so
-	 * val = 0x4 really means "bit 2, index starts at bit 0"
-	 */
+	* FIXME need a mux-specific flag to determine if val is
+	* bitwise or numeric
+	* e.g. sys_clkin_ck's clksel field is 3 bits wide, but ranges from 0x1
+	* to 0x7 (index starts at one)
+	* OTOH, pmd_trace_clk_mux_ck uses a separate bit for each clock, so
+	* val = 0x4 really means "bit 2, index starts at bit 0"
+	*/
 	val = clk_readl(mux->reg) >> mux->shift;
 	val &= mux->mask;
 
@@ -138,7 +139,7 @@ struct clk *clk_register_mux_table(struct device *dev, const char *name,
 	/* allocate the mux */
 	mux = kzalloc(sizeof(struct clk_mux), GFP_KERNEL);
 	if (!mux) {
-		pr_err("%s: could not allocate mux clk\n", __func__);
+		/*pr_err("%s: could not allocate mux clk\n", __func__);*/
 		return ERR_PTR(-ENOMEM);
 	}
 
-- 
2.1.0



             reply	other threads:[~2015-09-29 20:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-29 20:53 Shivani Bhardwaj [this message]
2015-09-29 21:23 ` [Outreachy kernel] [PATCH] Drivers: clk: clk-mux: fixed line exceeding char limit and irrelevant messages Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150929205325.GA10085@ubuntu \
    --to=shivanib134@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.