From mboxrd@z Thu Jan 1 00:00:00 1970 From: "davej@codemonkey.org.uk" Subject: Re: [regression] [git pull] drm for 4.3 Date: Tue, 29 Sep 2015 21:07:22 -0400 Message-ID: <20150930010722.GA19042@codemonkey.org.uk> References: <20150907184559.GA18393@codemonkey.org.uk> <20150921184849.GA25222@codemonkey.org.uk> <56016D01.5010708@virtuousgeek.org> <20150922151355.GX3383@phenom.ffwll.local> <20150922161558.GB24128@intel.com> <20150923014909.GA18010@codemonkey.org.uk> <1443006475.22058.1.camel@intel.com> <20150924035108.GA19724@codemonkey.org.uk> <877fng54or.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <877fng54or.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jani Nikula Cc: "torvalds@linux-foundation.org" , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "Miramontes Caton, Jairo Daniel" , "Vetter, Daniel" , "Lankhorst, Maarten" List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBTZXAgMjQsIDIwMTUgYXQgMDQ6MjY6MjhQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6CiA+IE9uIFRodSwgMjQgU2VwIDIwMTUsICJkYXZlakBjb2RlbW9ua2V5Lm9yZy51ayIgPGRh dmVqQGNvZGVtb25rZXkub3JnLnVrPiB3cm90ZToKID4gPiBPbiBXZWQsIFNlcCAyMywgMjAxNSBh dCAxMTowNzo1NkFNICswMDAwLCBMYW5raG9yc3QsIE1hYXJ0ZW4gd3JvdGU6CiA+ID4gID4gSGV5 LAogPiA+ICA+IAogPiA+ICA+IERhdmUgSm9uZXMgc2NocmVlZiBvcCBkaSAyMi0wOS0yMDE1IG9t IDIxOjQ5IFstMDQwMF06CiA+ID4gID4gPiBPbiBUdWUsIFNlcCAyMiwgMjAxNSBhdCAwOToxNTo1 OEFNIC0wNzAwLCBNYXR0IFJvcGVyIHdyb3RlOgogPiA+ICA+ID4gID4gT24gVHVlLCBTZXAgMjIs IDIwMTUgYXQgMDU6MTM6NTVQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3cm90ZToKID4gPiAgPiA+ ICA+ID4gT24gVHVlLCBTZXAgMjIsIDIwMTUgYXQgMDg6MDA6MTdBTSAtMDcwMCwgSmVzc2UgQmFy bmVzIHdyb3RlOgogPiA+ICA+ID4gID4gPiA+IENjJ2luZyBNYWFydGVuIGFuZCBNYXR0OyBJJ20g Z3Vlc3NpbmcgdGhpcyBtYXkgYmUgcmVsYXRlZCB0byBvbmUgb2YKID4gPiAgPiA+ICA+ID4gPiB0 aGVpciByZWNlbnQgcGF0Y2hlcy4KID4gPiAgPiA+ICA+IAogPiA+ICA+ID4gID4gU291bmRzIGxp a2UgdGhpcyBzaG93ZWQgdXAgYmVmb3JlIG15IHJlY2VudCB3b3JrLCBidXQgSSB0aGluayBJIG1p Z2h0CiA+ID4gID4gPiAgPiBoYXZlIHNlZW4gc2ltaWxhciBwcm9ibGVtcyB3aGlsZSB3b3JraW5n IG9uIGF0b21pYyB3YXRlcm1hcmtzOyB0aGUKID4gPiAgPiA+ICA+IGlzc3VlcyBJIHdhcyBzZWVp bmcgd2VyZSBiZWNhdXNlIHRoZSBpbml0aWFsIGhhcmR3YXJlIHJlYWRvdXQgY291bGQKID4gPiAg PiA+ICA+IGxlYXZlIHByaW1hcnktPnZpc2libGUgc2V0IHRvIHRydWUgZXZlbiB3aGVuIHRoZSBD UlRDIHdhcyBvZmYuICBNeQogPiA+ICA+ID4gID4gc2VyaWVzICh3aGljaCBpcyBzdGlsbCB1bmRl ciBkZXZlbG9wbWVudCkgY29udGFpbnMgdGhpcyBwYXRjaCB0byBmaXgKID4gPiAgPiA+ICA+IHRo YXQ6CiA+ID4gID4gPiAgPiAKID4gPiAgPiA+ICA+ICAgICAgICAgaHR0cDovL3BhdGNod29yay5m cmVlZGVza3RvcC5vcmcvcGF0Y2gvNTk1NjQvCiA+ID4gID4gPiAgPiAKID4gPiAgPiA+ICA+IERv ZXMgYXBwbHlpbmcgdGhhdCBoZWxwIHdpdGggdGhlIHByb2JsZW1zIHJlcG9ydGVkIGhlcmU/CiA+ ID4gID4gPiAKID4gPiAgPiA+IE5vIGRpZmZlcmVuY2UgYXQgYWxsIGZvciBtZS4KID4gPiAgPiBM b29rcyBsaWtlIGEgKHJlb3BlbmVkKSBkdXAgb2YgOTE5NTI/CiA+ID4gID4gCiA+ID4gID4gQ2Fu IHlvdSBhcHBseSAiW1BBVENIXSBkcm0vaTkxNTogQWRkIHByaW1hcnkgcGxhbmUgdG8gbWFzayBp ZiBpdCdzCiA+ID4gID4gdmlzaWJsZSIsIGFuZCBnZXQgbWUgdGhlIHJlc3VsdHM/CiA+ID4KID4g PiBUaGlzIGRvZXNuJ3QgYXBwbHkgb24gdG9wIG9mIExpbnVzJyBjdXJyZW50IHRyZWUuCiA+ID4g SWYgeW91IGxldCBtZSBrbm93IHdoYXQgaXQncyBkZXBlbmRhbnQgb24sIEknbGwgZG8gYSBidWls ZCB3aXRoCiA+ID4gdGhvc2UgcGF0Y2hlcyB0b21vcnJvdy4KID4gCiA+IEl0J3Mgbm93IHBhcnQg b2YgdGhlIGRybS1pbnRlbC1maXhlcyBwdWxsIHJlcXVlc3QgWzFdLCBtYXliZSBpdCdzCiA+IGVh c2llc3QgdG8gcHVsbCB0aGF0IGluPyBKdXN0IGZvdXIgY29tbWl0cyBvbiB0b3Agb2YKID4gdjQu My1yYzIuIEFsdGVybmF0aXZlbHkgcGljayBpdCB1cCBmcm9tIG91ciByZXBvIFsyXS4KClRoZSB3 YXJuaW5nIG9uIGJvb3Qgc2VlbXMgdG8gYmUgZ29uZSBhcyBvZiByYzMsIGJ1dCBJIGNhbiBub3cg dHJpZ2dlciB0aGlzIHByZXR0eSBlYXNpbHkuLgoKV0FSTklORzogQ1BVOiAyIFBJRDogMjg5MTEg YXQgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYzo4ODkgZHJtX2F0b21pY19nZXRfcHJvcGVy dHkrMHgyNDQvMHgyZDAoKQpDUFU6IDIgUElEOiAyODkxMSBDb21tOiB0cmluaXR5LWMzMTMgTm90 IHRhaW50ZWQgNC4zLjAtcmMzLXRoaW5rKyAjMTQKIDAwMDAwMDAwMDAwMDAzNzkgZmZmZjg4MDFh MTM3N2M4OCBmZmZmZmZmZjhlMzVkNWVjIDAwMDAwMDAwMDAwMDAwMDAKIGZmZmY4ODAxYTEzNzdj YzAgZmZmZmZmZmY4ZTA3YTg2MiBmZmZmODgwNTAwYjM5MmI4IGZmZmY4ODA1MDBhMTMwMDgKIGZm ZmY4ODA1MDBiMzkyOTAgZmZmZjg4MDRmZTM4MDZkOCBmZmZmODgwMDNmYTQ1NjY4IGZmZmY4ODAx YTEzNzdjZDAKQ2FsbCBUcmFjZToKIFs8ZmZmZmZmZmY4ZTM1ZDVlYz5dIGR1bXBfc3RhY2srMHg0 ZS8weDgyCiBbPGZmZmZmZmZmOGUwN2E4NjI+XSB3YXJuX3Nsb3dwYXRoX2NvbW1vbisweDgyLzB4 YzAKIFs8ZmZmZmZmZmY4ZTA3YTk1YT5dIHdhcm5fc2xvd3BhdGhfbnVsbCsweDFhLzB4MjAKIFs8 ZmZmZmZmZmY4ZTQ4ZWZjND5dIGRybV9hdG9taWNfZ2V0X3Byb3BlcnR5KzB4MjQ0LzB4MmQwCiBb PGZmZmZmZmZmOGU0N2M3ZmM+XSBkcm1fb2JqZWN0X3Byb3BlcnR5X2dldF92YWx1ZSsweDZjLzB4 NzAKIFs8ZmZmZmZmZmY4ZTQ3YTQxZj5dIGRwbXNfc2hvdysweDJmLzB4NzAKIFs8ZmZmZmZmZmY4 ZTU0Y2UzMD5dIGRldl9hdHRyX3Nob3crMHgyMC8weDUwCiBbPGZmZmZmZmZmOGUyN2FlOTE+XSA/ IHN5c2ZzX2ZpbGVfb3BzKzB4NDEvMHg2MAogWzxmZmZmZmZmZjhlMjdiMWE3Pl0gc3lzZnNfa2Zf c2VxX3Nob3crMHhiNy8weDExMAogWzxmZmZmZmZmZjhlMjc5OWE2Pl0ga2VybmZzX3NlcV9zaG93 KzB4MjYvMHgzMAogWzxmZmZmZmZmZjhlMjFiYmE2Pl0gc2VxX3JlYWQrMHhlNi8weDQzMAogWzxm ZmZmZmZmZjhlMjdhM2Y3Pl0ga2VybmZzX2ZvcF9yZWFkKzB4MTI3LzB4MTcwCiBbPGZmZmZmZmZm OGU3ZTk4N2I+XSA/IG11dGV4X2xvY2tfbmVzdGVkKzB4MjZiLzB4M2YwCiBbPGZmZmZmZmZmOGUx ZjNhZjg+XSBfX3Zmc19yZWFkKzB4MjgvMHhlMAogWzxmZmZmZmZmZjhlN2U5ODk3Pl0gPyBtdXRl eF9sb2NrX25lc3RlZCsweDI4Ny8weDNmMAogWzxmZmZmZmZmZjhlMjE0YzA5Pl0gPyBfX2ZkZ2V0 X3BvcysweDQ5LzB4NTAKIFs8ZmZmZmZmZmY4ZTIxNGMwOT5dID8gX19mZGdldF9wb3MrMHg0OS8w eDUwCiBbPGZmZmZmZmZmOGUxZjQzYzY+XSB2ZnNfcmVhZCsweDg2LzB4MTMwCiBbPGZmZmZmZmZm OGUxZjUwYTk+XSBTeVNfcmVhZCsweDQ5LzB4YjAKIFs8ZmZmZmZmZmY4ZTdlZGVkNz5dIGVudHJ5 X1NZU0NBTExfNjRfZmFzdHBhdGgrMHgxMi8weDZmCi0tLVsgZW5kIHRyYWNlIGUwNTMwNjNjNjk3 YTEzNTUgXS0tLQoKIDg4NyAgICAgICAgIGNhc2UgRFJNX01PREVfT0JKRUNUX0NPTk5FQ1RPUjog ewogODg4ICAgICAgICAgICAgICAgICBzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yID0g b2JqX3RvX2Nvbm5lY3RvcihvYmopOwogODg5ICAgICAgICAgICAgICAgICBXQVJOX09OKCFkcm1f bW9kZXNldF9pc19sb2NrZWQoJmRldi0+bW9kZV9jb25maWcuY29ubmVjdGlvbl9tdXRleCkpOwog ODkwICAgICAgICAgICAgICAgICByZXQgPSBkcm1fYXRvbWljX2Nvbm5lY3Rvcl9nZXRfcHJvcGVy dHkoY29ubmVjdG9yLAogODkxICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29ubmVj dG9yLT5zdGF0ZSwgcHJvcGVydHksIHZhbCk7CiA4OTIgICAgICAgICAgICAgICAgIGJyZWFrOwog ODkzICAgICAgICAgfQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752320AbbI3BHl (ORCPT ); Tue, 29 Sep 2015 21:07:41 -0400 Received: from arcturus.aphlor.org ([188.246.204.175]:40434 "EHLO arcturus.aphlor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751369AbbI3BHh (ORCPT ); Tue, 29 Sep 2015 21:07:37 -0400 Date: Tue, 29 Sep 2015 21:07:22 -0400 From: "davej@codemonkey.org.uk" To: Jani Nikula Cc: "Lankhorst, Maarten" , "linux-kernel@vger.kernel.org" , "torvalds@linux-foundation.org" , "intel-gfx@lists.freedesktop.org" , "Roper, Matthew D" , "Vetter, Daniel" , "dri-devel@lists.freedesktop.org" , "jbarnes@virtuousgeek.org" , "airlied@linux.ie" , "Miramontes Caton, Jairo Daniel" Subject: Re: [regression] [git pull] drm for 4.3 Message-ID: <20150930010722.GA19042@codemonkey.org.uk> Mail-Followup-To: "davej@codemonkey.org.uk" , Jani Nikula , "Lankhorst, Maarten" , "linux-kernel@vger.kernel.org" , "torvalds@linux-foundation.org" , "intel-gfx@lists.freedesktop.org" , "Roper, Matthew D" , "Vetter, Daniel" , "dri-devel@lists.freedesktop.org" , "jbarnes@virtuousgeek.org" , "airlied@linux.ie" , "Miramontes Caton, Jairo Daniel" References: <20150907184559.GA18393@codemonkey.org.uk> <20150921184849.GA25222@codemonkey.org.uk> <56016D01.5010708@virtuousgeek.org> <20150922151355.GX3383@phenom.ffwll.local> <20150922161558.GB24128@intel.com> <20150923014909.GA18010@codemonkey.org.uk> <1443006475.22058.1.camel@intel.com> <20150924035108.GA19724@codemonkey.org.uk> <877fng54or.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <877fng54or.fsf@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-Score: -2.9 (--) X-Spam-Report: Spam report generated by SpamAssassin on "arcturus.aphlor.org" Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Authenticated-User: davej@codemonkey.org.uk Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 24, 2015 at 04:26:28PM +0300, Jani Nikula wrote: > On Thu, 24 Sep 2015, "davej@codemonkey.org.uk" wrote: > > On Wed, Sep 23, 2015 at 11:07:56AM +0000, Lankhorst, Maarten wrote: > > > Hey, > > > > > > Dave Jones schreef op di 22-09-2015 om 21:49 [-0400]: > > > > On Tue, Sep 22, 2015 at 09:15:58AM -0700, Matt Roper wrote: > > > > > On Tue, Sep 22, 2015 at 05:13:55PM +0200, Daniel Vetter wrote: > > > > > > On Tue, Sep 22, 2015 at 08:00:17AM -0700, Jesse Barnes wrote: > > > > > > > Cc'ing Maarten and Matt; I'm guessing this may be related to one of > > > > > > > their recent patches. > > > > > > > > > > Sounds like this showed up before my recent work, but I think I might > > > > > have seen similar problems while working on atomic watermarks; the > > > > > issues I was seeing were because the initial hardware readout could > > > > > leave primary->visible set to true even when the CRTC was off. My > > > > > series (which is still under development) contains this patch to fix > > > > > that: > > > > > > > > > > http://patchwork.freedesktop.org/patch/59564/ > > > > > > > > > > Does applying that help with the problems reported here? > > > > > > > > No difference at all for me. > > > Looks like a (reopened) dup of 91952? > > > > > > Can you apply "[PATCH] drm/i915: Add primary plane to mask if it's > > > visible", and get me the results? > > > > This doesn't apply on top of Linus' current tree. > > If you let me know what it's dependant on, I'll do a build with > > those patches tomorrow. > > It's now part of the drm-intel-fixes pull request [1], maybe it's > easiest to pull that in? Just four commits on top of > v4.3-rc2. Alternatively pick it up from our repo [2]. The warning on boot seems to be gone as of rc3, but I can now trigger this pretty easily.. WARNING: CPU: 2 PID: 28911 at drivers/gpu/drm/drm_atomic.c:889 drm_atomic_get_property+0x244/0x2d0() CPU: 2 PID: 28911 Comm: trinity-c313 Not tainted 4.3.0-rc3-think+ #14 0000000000000379 ffff8801a1377c88 ffffffff8e35d5ec 0000000000000000 ffff8801a1377cc0 ffffffff8e07a862 ffff880500b392b8 ffff880500a13008 ffff880500b39290 ffff8804fe3806d8 ffff88003fa45668 ffff8801a1377cd0 Call Trace: [] dump_stack+0x4e/0x82 [] warn_slowpath_common+0x82/0xc0 [] warn_slowpath_null+0x1a/0x20 [] drm_atomic_get_property+0x244/0x2d0 [] drm_object_property_get_value+0x6c/0x70 [] dpms_show+0x2f/0x70 [] dev_attr_show+0x20/0x50 [] ? sysfs_file_ops+0x41/0x60 [] sysfs_kf_seq_show+0xb7/0x110 [] kernfs_seq_show+0x26/0x30 [] seq_read+0xe6/0x430 [] kernfs_fop_read+0x127/0x170 [] ? mutex_lock_nested+0x26b/0x3f0 [] __vfs_read+0x28/0xe0 [] ? mutex_lock_nested+0x287/0x3f0 [] ? __fdget_pos+0x49/0x50 [] ? __fdget_pos+0x49/0x50 [] vfs_read+0x86/0x130 [] SyS_read+0x49/0xb0 [] entry_SYSCALL_64_fastpath+0x12/0x6f ---[ end trace e053063c697a1355 ]--- 887 case DRM_MODE_OBJECT_CONNECTOR: { 888 struct drm_connector *connector = obj_to_connector(obj); 889 WARN_ON(!drm_modeset_is_locked(&dev->mode_config.connection_mutex)); 890 ret = drm_atomic_connector_get_property(connector, 891 connector->state, property, val); 892 break; 893 }