Re: [Outreachy kernel] [PATCH] Drivers: staging: wlan-ng: p80211conv: replaced functions for copying/comparing ethernet addresses

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Sep 30, 2015 at 03:46:08AM +0530, Shivani Bhardwaj wrote:
> Replaced the function memcpy() by ether_addr_copy() and, memcmp() by
> ether_addr_equal() as these functions are more preferable for copying
> and comparing the ethernet addresses respectively.
> Also fixed the issue of character limit of 80 per line and removed
> one unnecessary statement.

When you start listing "other" things you did in a patch, that's a huge
sign that you need to split this up into different patches.  Remember,
it's "only one thing per patch".

Also, you can't just do a search/replace for ether_addr_equal(),
otherwise we would have done that a long time ago.  You have to be able
to prove that this function will work properly, and that depends on
knowing the layout of the structure to ensure that everything is aligned
properly.  Look at how other people have made this change in the
drivers/staging/ tree in the past for the type of proof that I need in
order to accept this change.

thanks,

greg k-h