From: David Gibson <david@gibson.dropbear.id.au>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: lvivier@redhat.com, thuth@redhat.com, qemu-devel@nongnu.org,
abologna@redhat.com, alex.williamson@redhat.com,
qemu-ppc@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 5/7] memory: Allow replay of IOMMU mapping notifications
Date: Wed, 30 Sep 2015 12:15:43 +1000 [thread overview]
Message-ID: <20150930021543.GC13035@voom.fritz.box> (raw)
In-Reply-To: <560A3AAE.7070005@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1030 bytes --]
On Tue, Sep 29, 2015 at 09:15:58AM +0200, Paolo Bonzini wrote:
>
>
> On 29/09/2015 05:30, David Gibson wrote:
> >> Maybe... The only issue is the "granularity" argument, which is
> >> not in memory_region_register_iommu_notifier. That makes me
> >> wonder if the replay and registration make sense as separate
> >> operations.
> >>
> >> What about adding a new function memory_region_iommu_replay and
> >> separate the two phases?
> >
> > Hm.. I'm not sure I see much advantage to separating the phases.
>
> It's just that it's (IMO) the clearest API. It shows how the
> granularity is only used for replay.
>
> > But I don't particularly object to the idea either. So, I think
> it's your
> > call.
>
> Yes, let's separate it.
Ok, I've done that, and sent a hopefull final respin of the series.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-09-30 2:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 4:33 [Qemu-devel] [PATCH 0/7] VFIO extensions to allow VFIO devices on spapr-pci-host-bridge David Gibson
2015-09-24 4:33 ` [Qemu-devel] [PATCH 1/7] vfio: Remove unneeded union from VFIOContainer David Gibson
2015-09-24 16:01 ` Alex Williamson
2015-09-25 5:14 ` David Gibson
2015-09-24 16:10 ` Thomas Huth
2015-09-24 4:33 ` [Qemu-devel] [PATCH 2/7] vfio: Generalize vfio_listener_region_add failure path David Gibson
2015-09-24 4:33 ` [Qemu-devel] [PATCH 3/7] vfio: Check guest IOVA ranges against host IOMMU capabilities David Gibson
2015-09-24 17:32 ` Alex Williamson
2015-09-25 5:20 ` David Gibson
2015-09-24 4:33 ` [Qemu-devel] [PATCH 4/7] vfio: Record host IOMMU's available IO page sizes David Gibson
2015-09-24 17:32 ` Alex Williamson
2015-09-25 5:21 ` David Gibson
2015-09-24 4:33 ` [Qemu-devel] [PATCH 5/7] memory: Allow replay of IOMMU mapping notifications David Gibson
2015-09-24 16:08 ` Laurent Vivier
2015-09-25 5:39 ` David Gibson
2015-09-24 17:32 ` Alex Williamson
2015-09-25 5:24 ` David Gibson
2015-09-25 11:25 ` Paolo Bonzini
2015-09-25 11:20 ` Paolo Bonzini
2015-09-25 11:33 ` David Gibson
2015-09-25 12:04 ` Paolo Bonzini
2015-09-26 6:54 ` David Gibson
2015-09-28 8:59 ` Paolo Bonzini
2015-09-29 3:30 ` David Gibson
2015-09-29 7:15 ` Paolo Bonzini
2015-09-30 2:15 ` David Gibson [this message]
2015-09-24 4:33 ` [Qemu-devel] [PATCH 6/7] vfio: Allow hotplug of containers onto existing guest IOMMU mappings David Gibson
2015-09-24 4:33 ` [Qemu-devel] [PATCH 7/7] vfio: Expose a VFIO PCI device's group for EEH David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150930021543.GC13035@voom.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=abologna@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.