Re: [PATCH v3 0/3] Add a couple of string-related functions

[David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1566 bytes --]

On Tue, Sep 29, 2015 at 11:09:05AM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> 
> These three patches add a couple of string functions that have proven
> useful in U-Boot's copy of libfdt, so they are likely to be useful for
> other users as well.
> 
> Patch 1 adds a function to count the number of strings in a property's
> value. This also adds a new DTS sample along with a small test program
> to validate the implemented functions.
> 
> Patch 2 adds a function to retrieve the index of a given string in any
> given property's value. This adds code to the test program introduced in
> the previous patch to exercise the new functionality.
> 
> Patch 3 adds a function to retrieve a string by index from a property's
> value. This extends the test program introduced in patch 1 to validate
> the new functionality.

Thanks, I've applied this.

I did end up making a couple of small changes.

First, I forgot to say earlier that I also wanted to change the
testcase name to stringlist* for clarity.

Second, Travis CI picked up some -Wshadow warnings: in a bunch of
places you were using 'index' as a variable name, which shadows the
libc index(3) function.  I'm not sure why that didn't show up on a
local "make check", but in any case I've changed thos to 'idx' to fix
it.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]