From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
peterhuewe@gmx.de, gregkh@linuxfoundation.org,
akpm@linux-foundation.org, Marcel Selhorst <tpmdd@selhorst.net>
Subject: Re: [PATCH 1/2] tpm, tpm_tis: use acpi_driver instead of pnp_driver
Date: Wed, 30 Sep 2015 07:04:55 +0100 [thread overview]
Message-ID: <20150930060455.GB7517@srcf.ucam.org> (raw)
In-Reply-To: <20150930055612.GA3874@intel.com>
On Wed, Sep 30, 2015 at 08:56:12AM +0300, Jarkko Sakkinen wrote:
> I found at least all the IDs listed from drivers/acpi/acpi_pnp.c but you
> might be right that they might be (don't know) with pnpbios.
The entries in acpi_pnp.c mean "If this device is declared in an ACPI
table, create a PNP device". TPMs are kind of at the cutoff where some
vendors may have shipped non-ACPI systems with TPMs that were declared
via pnpbios, so there's a (small) risk that there are some people using
TPMs tied to PNP devices without a corresponding ACPI device.
> Maybe a better solution would to have two tables and have only MSFT0101
> in tpm_acpi_tbl in order to make sure that old functionality is not
> broken up because we want this also to the stable kernels.
I'd agree here.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2015-09-30 6:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 17:07 [PATCH 0/2] Fix tpm_tis ACPI issue with TPM 2.0 Jarkko Sakkinen
2015-09-29 17:07 ` [PATCH 1/2] tpm, tpm_tis: use acpi_driver instead of pnp_driver Jarkko Sakkinen
2015-09-29 17:26 ` Jason Gunthorpe
2015-09-30 5:56 ` Jarkko Sakkinen
2015-09-30 6:04 ` Matthew Garrett [this message]
2015-09-29 17:30 ` Matthew Garrett
2015-09-30 5:58 ` Jarkko Sakkinen
2015-09-30 6:02 ` Matthew Garrett
2015-09-29 17:07 ` [PATCH 2/2] tpm, tpm_tis: detect TPM2 FIFO devices based on HID Jarkko Sakkinen
2015-09-29 17:43 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150930060455.GB7517@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.